[logging] Bugfix: LinuxPerfBasicLogger should log JS functions

lukealbao · V8 LUCI CQ · commit f7d000a7ae7b · 2023-10-19T17:37:41.000Z
This patch fixes a typo that was introduced in commit c51041f / https://chromium-review.googlesource.com/c/v8/v8/+/2336793, which reversed the behavior of the perf_basic_prof_only_functions flag. This also refactors the equivalent guard in LinuxPerfJitLogger to use the same inline CodeKind API for identifying JS Functions. This is unrelated to the bug, but it seems a fair rider to add on here. Bug: v8:14387 Change-Id: I25766b0d45f4c65dfec5ae01e094a1ed94111054 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4954225 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#90501}
diff --git a/AUTHORS b/AUTHORS
@@ -181,6 +181,7 @@ Loo Rong Jie <loorongjie@gmail.com>
 Lu Yahan <yahan@iscas.ac.cn>
 Ludovic Mermod <ludovic.mermod@gmail.com>
 Luis Reis <luis.m.reis@gmail.com>
+Luke Albao <lukealbao@gmail.com>
 Luke Zarko <lukezarko@gmail.com>
 Ma Aiguo <maaiguo@uniontech.com>
 Maciej Małecki <me@mmalecki.com>
diff --git a/src/diagnostics/perf-jit.cc b/src/diagnostics/perf-jit.cc
@@ -43,6 +43,7 @@
 #include "src/codegen/assembler.h"
 #include "src/codegen/source-position-table.h"
 #include "src/diagnostics/eh-frame.h"
+#include "src/objects/code-kind.h"
 #include "src/objects/objects-inl.h"
 #include "src/objects/shared-function-info.h"
 #include "src/snapshot/embedded/embedded-data.h"
@@ -225,9 +226,7 @@ void LinuxPerfJitLogger::LogRecordedBuffer(
   DisallowGarbageCollection no_gc;
   if (v8_flags.perf_basic_prof_only_functions) {
     CodeKind code_kind = abstract_code->kind(isolate_);
-    if (code_kind != CodeKind::INTERPRETED_FUNCTION &&
-        code_kind != CodeKind::TURBOFAN && code_kind != CodeKind::MAGLEV &&
-        code_kind != CodeKind::BASELINE) {
+    if (!CodeKindIsJSFunction(code_kind)) {
       return;
     }
   }
diff --git a/src/logging/log.cc b/src/logging/log.cc
@@ -446,7 +446,7 @@ void LinuxPerfBasicLogger::LogRecordedBuffer(Tagged<AbstractCode> code,
   DisallowGarbageCollection no_gc;
   PtrComprCageBase cage_base(isolate_);
   if (v8_flags.perf_basic_prof_only_functions &&
-      CodeKindIsBuiltinOrJSFunction(code->kind(cage_base))) {
+      !CodeKindIsBuiltinOrJSFunction(code->kind(cage_base))) {
     return;
   }
 

-Original file line number
+Diff line change
 Lu Yahan <[email protected]>
 Ludovic Mermod <[email protected]>
 Luis Reis <[email protected]>
 +Luke Albao <[email protected]>
 Luke Zarko <[email protected]>
 Ma Aiguo <[email protected]>
 Maciej Małecki <[email protected]>
Original file line number	Diff line number	Diff line change
`@@ -446,7 +446,7 @@ void LinuxPerfBasicLogger::LogRecordedBuffer(Tagged<AbstractCode> code,`
`446`	`446`	`DisallowGarbageCollection no_gc;`
`447`	`447`	`PtrComprCageBase cage_base(isolate_);`
`448`	`448`	`if (v8_flags.perf_basic_prof_only_functions &&`
`449`		`- CodeKindIsBuiltinOrJSFunction(code->kind(cage_base))) {`
	`449`	`+ !CodeKindIsBuiltinOrJSFunction(code->kind(cage_base))) {`
`450`	`450`	`return;`
`451`	`451`	`}`
`452`	`452`