[inspector] should ignore asyncTask* with null

alexkozy · Commit Bot · commit f4a2b7f3e015 · 2017-10-03T00:08:37.000Z
In V8Debugger code we don't expect task_id == null, e.g. asyncTaskStartedForStepping will trigger debug break on null as task_id. Let's filter task_id == null out. This issue is originally filed in Node.js: nodejs/node#15464 R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c Reviewed-on: https://chromium-review.googlesource.com/695808 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48265}
diff --git a/src/inspector/v8-inspector-impl.cc b/src/inspector/v8-inspector-impl.cc
@@ -289,18 +289,22 @@ std::unique_ptr<V8StackTrace> V8InspectorImpl::captureStackTrace(
 
 void V8InspectorImpl::asyncTaskScheduled(const StringView& taskName, void* task,
                                          bool recurring) {
+  if (!task) return;
   m_debugger->asyncTaskScheduled(taskName, task, recurring);
 }
 
 void V8InspectorImpl::asyncTaskCanceled(void* task) {
+  if (!task) return;
   m_debugger->asyncTaskCanceled(task);
 }
 
 void V8InspectorImpl::asyncTaskStarted(void* task) {
+  if (!task) return;
   m_debugger->asyncTaskStarted(task);
 }
 
 void V8InspectorImpl::asyncTaskFinished(void* task) {
+  if (!task) return;
   m_debugger->asyncTaskFinished(task);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -289,18 +289,22 @@ std::unique_ptr<V8StackTrace> V8InspectorImpl::captureStackTrace(`
`289`	`289`
`290`	`290`	`void V8InspectorImpl::asyncTaskScheduled(const StringView& taskName, void* task,`
`291`	`291`	`bool recurring) {`
	`292`	`+ if (!task) return;`
`292`	`293`	`m_debugger->asyncTaskScheduled(taskName, task, recurring);`
`293`	`294`	`}`
`294`	`295`
`295`	`296`	`void V8InspectorImpl::asyncTaskCanceled(void* task) {`
	`297`	`+ if (!task) return;`
`296`	`298`	`m_debugger->asyncTaskCanceled(task);`
`297`	`299`	`}`
`298`	`300`
`299`	`301`	`void V8InspectorImpl::asyncTaskStarted(void* task) {`
	`302`	`+ if (!task) return;`
`300`	`303`	`m_debugger->asyncTaskStarted(task);`
`301`	`304`	`}`
`302`	`305`
`303`	`306`	`void V8InspectorImpl::asyncTaskFinished(void* task) {`
	`307`	`+ if (!task) return;`
`304`	`308`	`m_debugger->asyncTaskFinished(task);`
`305`	`309`	`}`
`306`	`310`