Repository navigation
Commit f331137
PPC: Fix safepoint record
This patch is needed after http://crrev.com/c/7899697 started failing
this test intermittently during GC on pntr compressed debug builds:
```
=== mjsunit/compiler/regress-crbug-1464516 ===
--- stderr ---
#
# Fatal error in ../../src/objects/tagged-impl.h, line 138
# Debug check failed: kCanBeWeak || (!IsSmi() == HAS_STRONG_HEAP_OBJECT_TAG(ptr_)).
```
PPC could emit a trampoline pool right after `MacroAssembler::Call`
returns which could make any subsequent `DefineSafepoint` calls
record the incorrect `pc_offset` as it then points to after the emitted pool.
This CL patches every "MacroAssembler::Call" site to record the pc_offset before the trampoline pool is emitted similar to how it's
done on riscv.
It's essentially porting the following changes to PPC:
f385232
2c6618f
Change-Id: I2095bce8b69b0c4f064117ed95ee2f3245436e62
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7918866
Reviewed-by: Darius Mercadier <[email protected]>
Reviewed-by: John <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#107921}1 parent d212697 commit f331137
3 files changed
Lines changed: 26 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
393 | 393 | | |
394 | 394 | | |
395 | 395 | | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
401 | 402 | | |
402 | 403 | | |
403 | 404 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
212 | 219 | | |
213 | 220 | | |
214 | 221 | | |
| |||
1381 | 1388 | | |
1382 | 1389 | | |
1383 | 1390 | | |
| 1391 | + | |
| 1392 | + | |
1384 | 1393 | | |
1385 | 1394 | | |
1386 | 1395 | | |
| |||
1459 | 1468 | | |
1460 | 1469 | | |
1461 | 1470 | | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
1462 | 1476 | | |
1463 | 1477 | | |
1464 | 1478 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
| 264 | + | |
264 | 265 | | |
265 | 266 | | |
266 | 267 | | |
| |||
288 | 289 | | |
289 | 290 | | |
290 | 291 | | |
| 292 | + | |
291 | 293 | | |
292 | 294 | | |
293 | 295 | | |
| |||
421 | 423 | | |
422 | 424 | | |
423 | 425 | | |
424 | | - | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
425 | 430 | | |
426 | 431 | | |
427 | 432 | | |
| |||
0 commit comments