Skip to content

Commit f320600

Browse files
sygV8 LUCI CQ
authored andcommitted
[wasm-gc] Only normalize JSObject targets in SetOrCopyDataProperties
Bug: 339458194 Change-Id: I4d6eebdd921971fa28d7c474535d978900ba633f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5527397 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/heads/main@{#93811}
1 parent 66c0bd3 commit f320600

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

src/objects/js-objects.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -434,9 +434,7 @@ Maybe<bool> JSReceiver::SetOrCopyDataProperties(
434434
Nothing<bool>());
435435

436436
if (!from->HasFastProperties() && target->HasFastProperties() &&
437-
!IsJSGlobalProxy(*target)) {
438-
// JSProxy is always in slow-mode.
439-
DCHECK(!IsJSProxy(*target));
437+
IsJSObject(*target) && !IsJSGlobalProxy(*target)) {
440438
// Convert to slow properties if we're guaranteed to overflow the number of
441439
// descriptors.
442440
int source_length;

0 commit comments

Comments
 (0)