[maglev] CreateRegExpLiteral can throw...

verwaest · V8 LUCI CQ · commit f2c545830d05 · 2024-05-16T14:17:50.000Z
... stack overflow Bug: v8:7700, 339759428 Change-Id: I3a38905c763f13f238a90bd6848ecca745bba180 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5544144 Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#93950}
diff --git a/src/maglev/maglev-ir.cc b/src/maglev/maglev-ir.cc
@@ -3846,6 +3846,7 @@ void CreateRegExpLiteral::GenerateCode(MaglevAssembler* masm,
       pattern().object(),                           // pattern
       Smi::FromInt(flags())                         // flags
   );
+  masm->DefineLazyDeoptPoint(lazy_deopt_info());
 }
 
 int GetTemplateObject::MaxCallStackArgs() const {
diff --git a/src/maglev/maglev-ir.h b/src/maglev/maglev-ir.h
@@ -5367,8 +5367,9 @@ class CreateRegExpLiteral
   int flags() const { return flags_; }
 
   // The implementation currently calls runtime.
-  static constexpr OpProperties kProperties =
-      OpProperties::Call() | OpProperties::NotIdempotent();
+  static constexpr OpProperties kProperties = OpProperties::Call() |
+                                              OpProperties::NotIdempotent() |
+                                              OpProperties::CanThrow();
 
   int MaxCallStackArgs() const;
   void SetValueLocationConstraints();

Original file line number	Diff line number	Diff line change
`@@ -3846,6 +3846,7 @@ void CreateRegExpLiteral::GenerateCode(MaglevAssembler* masm,`
`3846`	`3846`	`pattern().object(), // pattern`
`3847`	`3847`	`Smi::FromInt(flags()) // flags`
`3848`	`3848`	`);`
	`3849`	`+ masm->DefineLazyDeoptPoint(lazy_deopt_info());`
`3849`	`3850`	`}`
`3850`	`3851`
`3851`	`3852`	`int GetTemplateObject::MaxCallStackArgs() const {`