[maglev] Cap inlining at MaxInliningId

verwaest · V8 LUCI CQ · commit f22ca7b61a92 · 2025-07-15T06:27:14.000-07:00
Bug: 430572435 Change-Id: I4f20bad6c99e9d3d5a959cb801485dfb117e9884 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6732846 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#101423}
diff --git a/src/codegen/source-position.h b/src/codegen/source-position.h
@@ -116,6 +116,8 @@ class SourcePosition final {
     value_ = InliningIdField::update(value_, inlining_id + 1);
   }
 
+  static constexpr int MaxInliningId() { return InliningIdField::kMax; }
+
   static const int kNotInlined = -1;
   static_assert(kNoSourcePosition == -1);
 
diff --git a/src/maglev/maglev-graph-builder.cc b/src/maglev/maglev-graph-builder.cc
@@ -8002,6 +8002,13 @@ ReduceResult MaglevGraphBuilder::BuildInlineFunction(
 
 bool MaglevGraphBuilder::CanInlineCall(compiler::SharedFunctionInfoRef shared,
                                        float call_frequency) {
+  if (static_cast<int>(graph()->inlined_functions().size()) >=
+      SourcePosition::MaxInliningId()) {
+    compilation_unit_->info()->set_could_not_inline_all_candidates();
+    TRACE_CANNOT_INLINE("maximum inlining ids");
+    return false;
+  }
+
   if (graph()->total_inlined_bytecode_size() >
       max_inlined_bytecode_size_cumulative()) {
     compilation_unit_->info()->set_could_not_inline_all_candidates();

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,8 @@ class SourcePosition final {`
`116`	`116`	`value_ = InliningIdField::update(value_, inlining_id + 1);`
`117`	`117`	`}`
`118`	`118`
	`119`	`+ static constexpr int MaxInliningId() { return InliningIdField::kMax; }`
	`120`	`+`
`119`	`121`	`static const int kNotInlined = -1;`
`120`	`122`	`static_assert(kNoSourcePosition == -1);`
`121`	`123`