[wasm] Avoid checking for scheduled_exceptions in the wasm deserialization

gahaas · Commit Bot · commit e921be5c4f2c · 2018-04-11T13:32:26.000Z
ValueDeserializer::ReadWasmModule does not call API functions, therefore there can be no scheduled_exceptions, and therefore we do not have to translate scheduled_exceptions to pending_exceptions. On the contrary, there can be pending_exceptions, which causes the call to RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION to crash. This CL fixes a crash in a layout test which was caused by another CL (https://crrev.com/c/975547). R=mstarzinger@chromium.org CC=​binji@chromium.org Change-Id: I3078a2a9a532b079b5a4ea604c2f3f777fa2e287 Reviewed-on: https://chromium-review.googlesource.com/1006794 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52547}
diff --git a/src/value-serializer.cc b/src/value-serializer.cc
@@ -1796,7 +1796,6 @@ MaybeHandle<JSObject> ValueDeserializer::ReadWasmModule() {
     result = isolate_->wasm_engine()->SyncCompile(
         isolate_, &thrower, wasm::ModuleWireBytes(wire_bytes));
   }
-  RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate_, JSObject);
   uint32_t id = next_id_++;
   if (!result.is_null()) {
     AddObjectWithID(id, result.ToHandleChecked());

Original file line number	Diff line number	Diff line change
`@@ -1796,7 +1796,6 @@ MaybeHandle<JSObject> ValueDeserializer::ReadWasmModule() {`
`1796`	`1796`	`result = isolate_->wasm_engine()->SyncCompile(`
`1797`	`1797`	`isolate_, &thrower, wasm::ModuleWireBytes(wire_bytes));`
`1798`	`1798`	`}`
`1799`		`- RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate_, JSObject);`
`1800`	`1799`	`uint32_t id = next_id_++;`
`1801`	`1800`	`if (!result.is_null()) {`
`1802`	`1801`	`AddObjectWithID(id, result.ToHandleChecked());`