Make sure the heap is in consistent state when calling allocation observers.

a1ph · Commit bot · commit e8e9c07e548e · 2016-05-04T14:40:18.000Z
The observer might want to lookup something in the heap, e.g. code objects it has in the call stack. BUG=v8:4959 LOG=N Review-Url: https://codereview.chromium.org/1948893002 Cr-Commit-Position: refs/heads/master@{#36027}
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
@@ -2444,7 +2444,6 @@ HeapObject* FreeList::Allocate(int size_in_bytes) {
   int new_node_size = 0;
   FreeSpace* new_node = FindNodeFor(size_in_bytes, &new_node_size);
   if (new_node == nullptr) return nullptr;
-  owner_->AllocationStep(new_node->address(), size_in_bytes);
 
   int bytes_left = new_node_size - size_in_bytes;
   DCHECK(bytes_left >= 0);
@@ -2490,6 +2489,8 @@ HeapObject* FreeList::Allocate(int size_in_bytes) {
                            new_node->address() + new_node_size);
   }
 
+  owner_->AllocationStep(new_node->address(), size_in_bytes);
+
   return new_node;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2444,7 +2444,6 @@ HeapObject* FreeList::Allocate(int size_in_bytes) {`
`2444`	`2444`	`int new_node_size = 0;`
`2445`	`2445`	`FreeSpace* new_node = FindNodeFor(size_in_bytes, &new_node_size);`
`2446`	`2446`	`if (new_node == nullptr) return nullptr;`
`2447`		`- owner_->AllocationStep(new_node->address(), size_in_bytes);`
`2448`	`2447`
`2449`	`2448`	`int bytes_left = new_node_size - size_in_bytes;`
`2450`	`2449`	`DCHECK(bytes_left >= 0);`
`@@ -2490,6 +2489,8 @@ HeapObject* FreeList::Allocate(int size_in_bytes) {`
`2490`	`2489`	`new_node->address() + new_node_size);`
`2491`	`2490`	`}`
`2492`	`2491`
	`2492`	`+ owner_->AllocationStep(new_node->address(), size_in_bytes);`
	`2493`	`+`
`2493`	`2494`	`return new_node;`
`2494`	`2495`	`}`
`2495`	`2496`