Skip to content

Commit e825c43

Browse files
jakobkummerowCommit Bot
authored andcommitted
Remove x87 port
Bug: v8:6550 Change-Id: I888f91db1fd842d1fef8a5fb749da229dfb6ab97 Reviewed-on: https://chromium-review.googlesource.com/575756 Reviewed-by: Benedikt Meurer <[email protected]> Reviewed-by: Daniel Clifford <[email protected]> Reviewed-by: Yang Guo <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/master@{#46746}
1 parent 973314f commit e825c43

82 files changed

Lines changed: 45 additions & 28602 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

BUILD.gn

Lines changed: 3 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,9 @@ declare_args() {
112112
v8_experimental_extra_library_files =
113113
[ "//test/cctest/test-experimental-extra.js" ]
114114

115-
v8_enable_gdbjit = ((v8_current_cpu == "x86" || v8_current_cpu == "x64" ||
116-
v8_current_cpu == "x87") && (is_linux || is_mac)) ||
117-
(v8_current_cpu == "ppc64" && is_linux)
115+
v8_enable_gdbjit =
116+
((v8_current_cpu == "x86" || v8_current_cpu == "x64") &&
117+
(is_linux || is_mac)) || (v8_current_cpu == "ppc64" && is_linux)
118118

119119
# Temporary flag to allow embedders to update their microtasks scopes
120120
# while rolling in a new version of V8.
@@ -439,9 +439,6 @@ config("toolchain") {
439439
ldflags += [ "/STACK:2097152" ]
440440
}
441441
}
442-
if (v8_current_cpu == "x87") {
443-
defines += [ "V8_TARGET_ARCH_X87" ]
444-
}
445442
if (is_android && v8_android_log_stdout) {
446443
defines += [ "V8_ANDROID_LOG_STDOUT" ]
447444
}
@@ -1039,11 +1036,6 @@ v8_source_set("v8_builtins_generators") {
10391036
### gcmole(arch:s390) ###
10401037
"src/builtins/s390/builtins-s390.cc",
10411038
]
1042-
} else if (v8_current_cpu == "x87") {
1043-
sources += [
1044-
### gcmole(arch:x87) ###
1045-
"src/builtins/x87/builtins-x87.cc",
1046-
]
10471039
}
10481040

10491041
if (!v8_enable_i18n_support) {
@@ -2313,37 +2305,6 @@ v8_source_set("v8_base") {
23132305
"src/s390/simulator-s390.cc",
23142306
"src/s390/simulator-s390.h",
23152307
]
2316-
} else if (v8_current_cpu == "x87") {
2317-
sources += [ ### gcmole(arch:x87) ###
2318-
"src/compiler/x87/code-generator-x87.cc",
2319-
"src/compiler/x87/instruction-codes-x87.h",
2320-
"src/compiler/x87/instruction-scheduler-x87.cc",
2321-
"src/compiler/x87/instruction-selector-x87.cc",
2322-
"src/debug/x87/debug-x87.cc",
2323-
"src/full-codegen/x87/full-codegen-x87.cc",
2324-
"src/ic/x87/access-compiler-x87.cc",
2325-
"src/ic/x87/handler-compiler-x87.cc",
2326-
"src/ic/x87/ic-x87.cc",
2327-
"src/regexp/x87/regexp-macro-assembler-x87.cc",
2328-
"src/regexp/x87/regexp-macro-assembler-x87.h",
2329-
"src/x87/assembler-x87-inl.h",
2330-
"src/x87/assembler-x87.cc",
2331-
"src/x87/assembler-x87.h",
2332-
"src/x87/code-stubs-x87.cc",
2333-
"src/x87/code-stubs-x87.h",
2334-
"src/x87/codegen-x87.cc",
2335-
"src/x87/codegen-x87.h",
2336-
"src/x87/cpu-x87.cc",
2337-
"src/x87/deoptimizer-x87.cc",
2338-
"src/x87/disasm-x87.cc",
2339-
"src/x87/frames-x87.cc",
2340-
"src/x87/frames-x87.h",
2341-
"src/x87/interface-descriptors-x87.cc",
2342-
"src/x87/macro-assembler-x87.cc",
2343-
"src/x87/macro-assembler-x87.h",
2344-
"src/x87/simulator-x87.cc",
2345-
"src/x87/simulator-x87.h",
2346-
]
23472308
}
23482309

23492310
configs = [ ":internal_config" ]

Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -255,14 +255,13 @@ endif
255255

256256
# Architectures and modes to be compiled. Consider these to be internal
257257
# variables, don't override them (use the targets instead).
258-
ARCHES = ia32 x64 arm arm64 mips mipsel mips64 mips64el x87 ppc ppc64 s390 \
259-
s390x
260-
ARCHES32 = ia32 arm mips mipsel x87 ppc s390
258+
ARCHES = ia32 x64 arm arm64 mips mipsel mips64 mips64el ppc ppc64 s390 s390x
259+
ARCHES32 = ia32 arm mips mipsel ppc s390
261260
DEFAULT_ARCHES = ia32 x64 arm
262261
MODES = release debug optdebug
263262
DEFAULT_MODES = release debug
264263
ANDROID_ARCHES = android_ia32 android_x64 android_arm android_arm64 \
265-
android_mipsel android_x87
264+
android_mipsel
266265

267266
# List of files that trigger Makefile regeneration:
268267
GYPFILES = third_party/icu/icu.gypi third_party/icu/icu.gyp \

gypfiles/standalone.gypi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,14 +262,14 @@
262262
# goma doesn't support PDB yet.
263263
'fastbuild%': 1,
264264
}],
265-
['((v8_target_arch=="ia32" or v8_target_arch=="x64" or v8_target_arch=="x87") and \
265+
['((v8_target_arch=="ia32" or v8_target_arch=="x64") and \
266266
(OS=="linux" or OS=="mac")) or (v8_target_arch=="ppc64" and OS=="linux")', {
267267
'v8_enable_gdbjit%': 1,
268268
}, {
269269
'v8_enable_gdbjit%': 0,
270270
}],
271271
['(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and \
272-
(v8_target_arch!="x87" and v8_target_arch!="x32")', {
272+
v8_target_arch!="x32"', {
273273
'clang%': 1,
274274
}, {
275275
'clang%': 0,
@@ -1207,7 +1207,7 @@
12071207
'-L<(android_libcpp_libs)/arm64-v8a',
12081208
],
12091209
}],
1210-
['target_arch=="ia32" or target_arch=="x87"', {
1210+
['target_arch=="ia32"', {
12111211
# The x86 toolchain currently has problems with stack-protector.
12121212
'cflags!': [
12131213
'-fstack-protector',

gypfiles/toolchain.gypi

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
'host_cxx_is_biarch%': 0,
145145
},
146146
}],
147-
['target_arch=="ia32" or target_arch=="x64" or target_arch=="x87" or \
147+
['target_arch=="ia32" or target_arch=="x64" or \
148148
target_arch=="ppc" or target_arch=="ppc64" or target_arch=="s390" or \
149149
target_arch=="s390x" or clang==1', {
150150
'variables': {
@@ -342,12 +342,6 @@
342342
'V8_TARGET_ARCH_IA32',
343343
],
344344
}], # v8_target_arch=="ia32"
345-
['v8_target_arch=="x87"', {
346-
'defines': [
347-
'V8_TARGET_ARCH_X87',
348-
],
349-
'cflags': ['-march=i586'],
350-
}], # v8_target_arch=="x87"
351345
['v8_target_arch=="mips" or v8_target_arch=="mipsel" \
352346
or v8_target_arch=="mips64" or v8_target_arch=="mips64el"', {
353347
'target_conditions': [
@@ -1006,9 +1000,8 @@
10061000
['(OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
10071001
or OS=="netbsd" or OS=="mac" or OS=="android" or OS=="qnx") and \
10081002
(v8_target_arch=="arm" or v8_target_arch=="ia32" or \
1009-
v8_target_arch=="x87" or v8_target_arch=="mips" or \
1010-
v8_target_arch=="mipsel" or v8_target_arch=="ppc" or \
1011-
v8_target_arch=="s390")', {
1003+
v8_target_arch=="mips" or v8_target_arch=="mipsel" or \
1004+
v8_target_arch=="ppc" or v8_target_arch=="s390")', {
10121005
'target_conditions': [
10131006
['_toolset=="host"', {
10141007
'conditions': [

src/assembler-inl.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
#include "src/mips64/assembler-mips64-inl.h"
2424
#elif V8_TARGET_ARCH_S390
2525
#include "src/s390/assembler-s390-inl.h"
26-
#elif V8_TARGET_ARCH_X87
27-
#include "src/x87/assembler-x87-inl.h"
2826
#else
2927
#error Unknown architecture.
3028
#endif

src/assembler.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
#include "src/regexp/mips64/regexp-macro-assembler-mips64.h" // NOLINT
8686
#elif V8_TARGET_ARCH_S390
8787
#include "src/regexp/s390/regexp-macro-assembler-s390.h" // NOLINT
88-
#elif V8_TARGET_ARCH_X87
89-
#include "src/regexp/x87/regexp-macro-assembler-x87.h" // NOLINT
9088
#else // Unknown architecture.
9189
#error "Unknown architecture."
9290
#endif // Target architecture.
@@ -1324,8 +1322,6 @@ ExternalReference ExternalReference::re_check_stack_guard_state(
13241322
function = FUNCTION_ADDR(RegExpMacroAssemblerMIPS::CheckStackGuardState);
13251323
#elif V8_TARGET_ARCH_S390
13261324
function = FUNCTION_ADDR(RegExpMacroAssemblerS390::CheckStackGuardState);
1327-
#elif V8_TARGET_ARCH_X87
1328-
function = FUNCTION_ADDR(RegExpMacroAssemblerX87::CheckStackGuardState);
13291325
#else
13301326
UNREACHABLE();
13311327
#endif

src/base/build_config.h

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,9 @@
7676
// Target architecture detection. This may be set externally. If not, detect
7777
// in the same way as the host architecture, that is, target the native
7878
// environment as presented by the compiler.
79-
#if !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_X87 && \
80-
!V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_ARM64 && !V8_TARGET_ARCH_MIPS && \
81-
!V8_TARGET_ARCH_MIPS64 && !V8_TARGET_ARCH_PPC && !V8_TARGET_ARCH_S390
79+
#if !V8_TARGET_ARCH_X64 && !V8_TARGET_ARCH_IA32 && !V8_TARGET_ARCH_ARM && \
80+
!V8_TARGET_ARCH_ARM64 && !V8_TARGET_ARCH_MIPS && !V8_TARGET_ARCH_MIPS64 && \
81+
!V8_TARGET_ARCH_PPC && !V8_TARGET_ARCH_S390
8282
#if defined(_M_X64) || defined(__x86_64__)
8383
#define V8_TARGET_ARCH_X64 1
8484
#elif defined(_M_IX86) || defined(__i386__)
@@ -129,8 +129,6 @@
129129
#else
130130
#define V8_TARGET_ARCH_32_BIT 1
131131
#endif
132-
#elif V8_TARGET_ARCH_X87
133-
#define V8_TARGET_ARCH_32_BIT 1
134132
#else
135133
#error Unknown target architecture pointer size
136134
#endif
@@ -181,8 +179,6 @@
181179
#else
182180
#define V8_TARGET_LITTLE_ENDIAN 1
183181
#endif
184-
#elif V8_TARGET_ARCH_X87
185-
#define V8_TARGET_LITTLE_ENDIAN 1
186182
#elif __BIG_ENDIAN__ // FOR PPCGR on AIX
187183
#define V8_TARGET_BIG_ENDIAN 1
188184
#elif V8_TARGET_ARCH_PPC_LE
@@ -199,8 +195,7 @@
199195
#error Unknown target architecture endianness
200196
#endif
201197

202-
#if defined(V8_TARGET_ARCH_IA32) || defined(V8_TARGET_ARCH_X64) || \
203-
defined(V8_TARGET_ARCH_X87)
198+
#if defined(V8_TARGET_ARCH_IA32) || defined(V8_TARGET_ARCH_X64)
204199
#define V8_TARGET_ARCH_STORES_RETURN_ADDRESS_ON_STACK 1
205200
#else
206201
#define V8_TARGET_ARCH_STORES_RETURN_ADDRESS_ON_STACK 0

src/builtins/x87/OWNERS

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)