Skip to content

Commit e74d691

Browse files
luyahanV8 LUCI CQ
authored andcommitted
[sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG
There is still a place to simplify. Bug: v8:11420, v8:11421 Change-Id: I774139c52d911323f162350532a493e70f518643 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885 Auto-Submit: Yahan Lu <[email protected]> Commit-Queue: Leszek Swirski <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/master@{#76296}
1 parent 2e3b1bd commit e74d691

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

src/baseline/baseline-batch-compiler.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@
66

77
// TODO(v8:11421): Remove #if once baseline compiler is ported to other
88
// architectures.
9-
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || \
10-
V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_MIPS64 || \
11-
V8_TARGET_ARCH_MIPS
9+
#include "src/flags/flags.h"
10+
#if ENABLE_SPARKPLUG
1211

1312
#include "src/baseline/baseline-compiler.h"
1413
#include "src/codegen/compiler.h"

src/builtins/builtins-internal-gen.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1053,9 +1053,7 @@ void Builtins::Generate_MemMove(MacroAssembler* masm) {
10531053

10541054
// TODO(v8:11421): Remove #if once baseline compiler is ported to other
10551055
// architectures.
1056-
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || \
1057-
V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_MIPS64 || \
1058-
V8_TARGET_ARCH_MIPS
1056+
#if ENABLE_SPARKPLUG
10591057
void Builtins::Generate_BaselineLeaveFrame(MacroAssembler* masm) {
10601058
EmitReturnBaseline(masm);
10611059
}

0 commit comments

Comments
 (0)