Skip to content

Commit e2e6dd8

Browse files
schuayV8 LUCI CQ
authored andcommitted
[regexp] Fix the demangling hack for profiling
The magic string is `.<`, not `.>`. See the linked code in pprof. This fixes the anti-demangling hack originally added in https://chromium-review.googlesource.com/c/v8/v8/+/5953393. Change-Id: Ifd1f1d7e867f6afd42695ada4677a461a81a71be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7048339 Auto-Submit: Jakob Linke <[email protected]> Reviewed-by: Patrick Thier <[email protected]> Commit-Queue: Patrick Thier <[email protected]> Commit-Queue: Jakob Linke <[email protected]> Cr-Commit-Position: refs/heads/main@{#103149}
1 parent 3a9cc96 commit e2e6dd8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/logging/log.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ void CodeEventLogger::RegExpCodeCreateEvent(DirectHandle<AbstractCode> code,
337337
// regexp patterns.
338338
name_buffer_->Reset();
339339
// https://github.com/google/pprof/blob/4cf4322d492d108a9d6526d10844e04792982cbb/internal/symbolizer/symbolizer.go#L312.
340-
name_buffer_->AppendBytes("RegExp.>");
340+
name_buffer_->AppendBytes("RegExp.<");
341341
name_buffer_->AppendBytes(" src: '");
342342
name_buffer_->AppendString(*source);
343343
name_buffer_->AppendBytes("' flags: '");

0 commit comments

Comments
 (0)