[parser] Reset the calls_eval flag after arrow head

verwaest · V8 LUCI CQ · commit e1e08901c26f · 2022-12-13T13:15:51.000Z
Otherwise it's propagated to the parent Bug: chromium:1394973 Change-Id: I178f9d5d863aec501525a783846d1df6d3031bb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4100687 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#84808}
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
@@ -929,6 +929,7 @@ void Scope::Snapshot::Reparent(DeclarationScope* new_parent) {
   // Move eval calls since Snapshot's creation into new_parent.
   if (outer_scope_->calls_eval_) {
     new_parent->RecordEvalCall();
+    outer_scope_->calls_eval_ = false;
     declaration_scope_->sloppy_eval_can_extend_vars_ = false;
   }
 }
diff --git a/test/mjsunit/regress/regress-crbug-1394973.js b/test/mjsunit/regress/regress-crbug-1394973.js
@@ -0,0 +1,7 @@
+// Copyright 2022 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --stress-lazy-source-positions
+
+((__v_0 = ((__v_0 =eval()) => {})()) => {})()

Original file line number	Diff line number	Diff line change
`@@ -929,6 +929,7 @@ void Scope::Snapshot::Reparent(DeclarationScope* new_parent) {`
`929`	`929`	`// Move eval calls since Snapshot's creation into new_parent.`
`930`	`930`	`if (outer_scope_->calls_eval_) {`
`931`	`931`	`new_parent->RecordEvalCall();`
	`932`	`+ outer_scope_->calls_eval_ = false;`
`932`	`933`	`declaration_scope_->sloppy_eval_can_extend_vars_ = false;`
`933`	`934`	`}`
`934`	`935`	`}`