Skip to content

Commit de1461b

Browse files
addaleaxCommit bot
authored andcommitted
Drop UniqueId from include/v8.h
It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539). This removes it assuming that leaving it in the header was an oversight. BUG=v8:5828 Review-Url: https://codereview.chromium.org/2732803002 Cr-Commit-Position: refs/heads/master@{#43605}
1 parent e592fc4 commit de1461b

4 files changed

Lines changed: 0 additions & 27 deletions

File tree

include/v8.h

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -155,30 +155,6 @@ class GlobalHandles;
155155
} // namespace internal
156156

157157

158-
/**
159-
* General purpose unique identifier.
160-
*/
161-
class UniqueId {
162-
public:
163-
explicit UniqueId(intptr_t data)
164-
: data_(data) {}
165-
166-
bool operator==(const UniqueId& other) const {
167-
return data_ == other.data_;
168-
}
169-
170-
bool operator!=(const UniqueId& other) const {
171-
return data_ != other.data_;
172-
}
173-
174-
bool operator<(const UniqueId& other) const {
175-
return data_ < other.data_;
176-
}
177-
178-
private:
179-
intptr_t data_;
180-
};
181-
182158
// --- Handles ---
183159

184160
#define TYPE_CHECK(T, S) \

test/cctest/test-api-interceptors.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ using ::v8::String;
3838
using ::v8::Symbol;
3939
using ::v8::TryCatch;
4040
using ::v8::Undefined;
41-
using ::v8::UniqueId;
4241
using ::v8::V8;
4342
using ::v8::Value;
4443

test/cctest/test-api.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ using ::v8::String;
8282
using ::v8::Symbol;
8383
using ::v8::TryCatch;
8484
using ::v8::Undefined;
85-
using ::v8::UniqueId;
8685
using ::v8::V8;
8786
using ::v8::Value;
8887

test/cctest/test-global-handles.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
#include "test/cctest/cctest.h"
3535

3636
using namespace v8::internal;
37-
using v8::UniqueId;
3837

3938
TEST(EternalHandles) {
4039
CcTest::InitializeVM();

0 commit comments

Comments
 (0)