[turbofan] do not optimize any stores for field type None

tebbi · V8 LUCI CQ · commit db83e72034c0 · 2022-10-26T09:57:43.000Z
Fixed: chromium:1378239 Change-Id: If9d05ed391175a7a3923ab2108231759e649bb44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3981277 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#83925}
diff --git a/src/compiler/access-info.cc b/src/compiler/access-info.cc
@@ -456,9 +456,15 @@ PropertyAccessInfo AccessInfoFactory::ComputeDataFieldAccessInfo(
             map, descriptor, details_representation));
   } else if (details_representation.IsHeapObject()) {
     if (descriptors_field_type->IsNone()) {
-      // Store is not safe if the field type was cleared.
-      if (access_mode == AccessMode::kStore) {
-        return Invalid();
+      switch (access_mode) {
+        case AccessMode::kStore:
+        case AccessMode::kStoreInLiteral:
+        case AccessMode::kDefine:
+          // Store is not safe if the field type was cleared.
+          return Invalid();
+        case AccessMode::kLoad:
+        case AccessMode::kHas:
+          break;
       }
 
       // The field type was cleared by the GC, so we don't know anything
