Mark MemCopyAndSwitchEndianness src input as const

miladfarca · V8 LUCI CQ · commit daf4656ba85e · 2026-02-24T05:09:10.000-08:00
Needed after this CL: http://crrev.com/c/7600437 Currently getting the following error: ``` candidate function not viable: no known conversion from 'const unsigned char *' to 'void *' ``` Change-Id: I0c0f065b822e0f95ffd06207d280fc8b7bab4403 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7601332 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Cr-Commit-Position: refs/heads/main@{#105413}
diff --git a/src/base/memcopy.h b/src/base/memcopy.h
@@ -181,20 +181,20 @@ V8_INLINE void MemMove(void* dest, const void* src, size_t size) {
 }
 
 #if V8_TARGET_BIG_ENDIAN
-inline void MemCopyAndSwitchEndianness(void* dst, void* src,
+inline void MemCopyAndSwitchEndianness(void* dst, const void* src,
                                        size_t num_elements,
                                        size_t element_size) {
-#define COPY_LOOP(type, reverse)                            \
-  {                                                         \
-    for (uint32_t i = 0; i < num_elements; i++) {           \
-      type t;                                               \
-      type* s = reinterpret_cast<type*>(src) + i;           \
-      type* d = reinterpret_cast<type*>(dst) + i;           \
-      memcpy(&t, reinterpret_cast<void*>(s), element_size); \
-      t = reverse(t);                                       \
-      memcpy(reinterpret_cast<void*>(d), &t, element_size); \
-    }                                                       \
-    return;                                                 \
+#define COPY_LOOP(type, reverse)                                  \
+  {                                                               \
+    for (uint32_t i = 0; i < num_elements; i++) {                 \
+      type t;                                                     \
+      const type* s = reinterpret_cast<const type*>(src) + i;     \
+      type* d = reinterpret_cast<type*>(dst) + i;                 \
+      memcpy(&t, reinterpret_cast<const void*>(s), element_size); \
+      t = reverse(t);                                             \
+      memcpy(reinterpret_cast<void*>(d), &t, element_size);       \
+    }                                                             \
+    return;                                                       \
   }
 
   switch (element_size) {
diff --git a/src/utils/memcopy.h b/src/utils/memcopy.h
@@ -32,7 +32,7 @@ inline void MemCopy(void* dest, const void* src, size_t size) {
 }
 
 #if V8_TARGET_BIG_ENDIAN
-inline void MemCopyAndSwitchEndianness(void* dst, void* src,
+inline void MemCopyAndSwitchEndianness(void* dst, const void* src,
                                        size_t num_elements,
                                        size_t element_size) {
   v8::base::MemCopyAndSwitchEndianness(dst, src, num_elements, element_size);

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ inline void MemCopy(void* dest, const void* src, size_t size) {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`#if V8_TARGET_BIG_ENDIAN`
`35`		`-inline void MemCopyAndSwitchEndianness(void* dst, void* src,`
	`35`	`+inline void MemCopyAndSwitchEndianness(void* dst, const void* src,`
`36`	`36`	`size_t num_elements,`
`37`	`37`	`size_t element_size) {`
`38`	`38`	`v8::base::MemCopyAndSwitchEndianness(dst, src, num_elements, element_size);`