Skip to content

Commit dadce25

Browse files
mi-acV8 LUCI CQ
authored andcommitted
[build] Fix arm64 build config
In multi-architecture builds, e.g. for Android, the current toolchain is reflected by the `v8_current_cpu`, not `v8_target_cpu`, as the target stays fixed for all varying sub-builds. Bug: 471444397 Change-Id: I09f7c94f9d90f24af565e9601892bf4e83d77681 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7321244 Reviewed-by: Camillo Bruni <[email protected]> Commit-Queue: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/heads/main@{#104463}
1 parent 4ccc488 commit dadce25

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

BUILD.gn

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,9 +1094,9 @@ if (target_os == "android") {
10941094
# msan builds.
10951095
# TODO(ishell): support all target archs and add V8_HAVE_TARGET_ARCH similar
10961096
# to V8_TARGET_OS_* and V8_HAVE_TARGET_OS defines.
1097-
if (v8_target_cpu == "arm64") {
1097+
if (v8_current_cpu == "arm64") {
10981098
enabled_external_v8_defines += [ "V8_TARGET_ARCH_ARM64" ]
1099-
} else if (v8_target_cpu == "ppc64") {
1099+
} else if (v8_current_cpu == "ppc64") {
11001100
enabled_external_v8_defines += [ "V8_TARGET_ARCH_PPC64" ]
11011101
}
11021102

0 commit comments

Comments
 (0)