[api] deprecate unused context size estimate.

hashseed · Commit Bot · commit da5b745dba38 · 2017-03-29T09:56:22.000Z
Change-Id: I8de170892f061a8b30d1e39d1a7d3b4e2fe9230d Reviewed-on: https://chromium-review.googlesource.com/461823 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#44222}
diff --git a/BUILD.gn b/BUILD.gn
@@ -1380,8 +1380,6 @@ v8_source_set("v8_base") {
     "src/compiler/wasm-linkage.cc",
     "src/compiler/zone-stats.cc",
     "src/compiler/zone-stats.h",
-    "src/context-measure.cc",
-    "src/context-measure.h",
     "src/contexts-inl.h",
     "src/contexts.cc",
     "src/contexts.h",
diff --git a/include/v8.h b/include/v8.h
@@ -8274,7 +8274,7 @@ class V8_EXPORT Context {
   /**
    * Estimate the memory in bytes retained by this context.
    */
-  size_t EstimatedSize();
+  V8_DEPRECATED("no longer supported", size_t EstimatedSize());
 
   /**
    * Stack-allocated class which sets the execution context for all
diff --git a/src/api.cc b/src/api.cc
@@ -29,7 +29,6 @@
 #include "src/code-stubs.h"
 #include "src/compiler-dispatcher/compiler-dispatcher.h"
 #include "src/compiler.h"
-#include "src/context-measure.h"
 #include "src/contexts.h"
 #include "src/conversions-inl.h"
 #include "src/counters.h"
@@ -6506,12 +6505,7 @@ void Context::SetErrorMessageForCodeGenerationFromStrings(Local<String> error) {
   context->set_error_message_for_code_gen_from_strings(*error_handle);
 }
 
-
-size_t Context::EstimatedSize() {
-  return static_cast<size_t>(
-      i::ContextMeasure(*Utils::OpenHandle(this)).Size());
-}
-
+size_t Context::EstimatedSize() { return 0; }
 
 MaybeLocal<v8::Object> ObjectTemplate::NewInstance(Local<Context> context) {
   PREPARE_FOR_EXECUTION(context, ObjectTemplate, NewInstance, Object);
diff --git a/src/context-measure.cc b/src/context-measure.cc
diff --git a/src/context-measure.h b/src/context-measure.h
diff --git a/src/v8.gyp b/src/v8.gyp
@@ -787,8 +787,6 @@
         'compiler-dispatcher/optimizing-compile-dispatcher.h',
         'compiler.cc',
         'compiler.h',
-        'context-measure.cc',
-        'context-measure.h',
         'contexts-inl.h',
         'contexts.cc',
         'contexts.h',
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
@@ -32,7 +32,6 @@
 #include "src/assembler-inl.h"
 #include "src/code-stubs.h"
 #include "src/compilation-cache.h"
-#include "src/context-measure.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/elements.h"
@@ -5867,53 +5866,6 @@ TEST(RemoveCodeFromSharedFunctionInfoButNotFromClosure) {
       "check(g1, g2);");
 }
 
-TEST(ContextMeasure) {
-  CcTest::InitializeVM();
-  v8::HandleScope scope(CcTest::isolate());
-  Isolate* isolate = CcTest::i_isolate();
-  LocalContext context;
-
-  int size_upper_limit = 0;
-  int count_upper_limit = 0;
-  HeapIterator it(CcTest::heap());
-  for (HeapObject* obj = it.next(); obj != NULL; obj = it.next()) {
-    size_upper_limit += obj->Size();
-    count_upper_limit++;
-  }
-
-  ContextMeasure measure(*isolate->native_context());
-
-  PrintF("Context size        : %d bytes\n", measure.Size());
-  PrintF("Context object count: %d\n", measure.Count());
-
-  CHECK_LE(1000, measure.Count());
-  CHECK_LE(50000, measure.Size());
-
-  CHECK_LE(measure.Count(), count_upper_limit);
-  CHECK_LE(measure.Size(), size_upper_limit);
-}
-
-TEST(ContextMeasureNoMap) {
-  CcTest::InitializeVM();
-  v8::HandleScope scope(CcTest::isolate());
-
-  Local<v8::Context> current_context = CcTest::isolate()->GetCurrentContext();
-  Local<v8::Context> other_context = v8::Context::New(CcTest::isolate());
-
-  CompileRun(current_context, "var x = []");
-
-  size_t original_size_current = current_context->EstimatedSize();
-  size_t original_size_other = other_context->EstimatedSize();
-
-  CompileRun(current_context, "x.a = 1;");
-
-  size_t new_size_current = current_context->EstimatedSize();
-  size_t new_size_other = other_context->EstimatedSize();
-
-  CHECK_LT(original_size_current, new_size_current);
-  CHECK_EQ(original_size_other, new_size_other);
-}
-
 TEST(ScriptIterator) {
   CcTest::InitializeVM();
   v8::HandleScope scope(CcTest::isolate());
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
@@ -25778,14 +25778,6 @@ TEST(FutexInterruption) {
 }
 
 
-TEST(EstimatedContextSize) {
-  v8::Isolate* isolate = CcTest::isolate();
-  v8::HandleScope scope(isolate);
-  LocalContext env;
-  CHECK(50000 < env->EstimatedSize());
-}
-
-
 static int nb_uncaught_exception_callback_calls = 0;
 
 
