Skip to content

Commit da41db3

Browse files
shaseleyV8 LUCI CQ
authored andcommitted
[api] Deprecate Isolate::[Get|Set]ContinuationPreservedEmbedderData()
V8_DEPRECATE_SOON -> V8_DEPRECATED These APIs are being deprecated in favor of Isolate::[Get|Set]ContinuationPreservedEmbedderDataV2(), which use v8::Data instead of v8::Value, allowing embedders to store v8::CppHeapExternal in CPED. Bug: 376599402 Change-Id: I85889cf538a60387e7811c8e719ef1e070c85ff6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6854264 Reviewed-by: Deepti Gandluri <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Commit-Queue: Scott Haseley <[email protected]> Cr-Commit-Position: refs/heads/main@{#101923}
1 parent 274a91b commit da41db3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

include/v8-isolate.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -970,14 +970,14 @@ class V8_EXPORT Isolate {
970970
* Returns the value that was set or restored by
971971
* SetContinuationPreservedEmbedderData(), if any.
972972
*/
973-
V8_DEPRECATE_SOON("Use GetContinuationPreservedEmbedderDataV2 instead")
973+
V8_DEPRECATED("Use GetContinuationPreservedEmbedderDataV2 instead")
974974
Local<Value> GetContinuationPreservedEmbedderData();
975975

976976
/**
977977
* Sets a value that will be stored on continuations and reset while the
978978
* continuation runs.
979979
*/
980-
V8_DEPRECATE_SOON("Use SetContinuationPreservedEmbedderDataV2 instead")
980+
V8_DEPRECATED("Use SetContinuationPreservedEmbedderDataV2 instead")
981981
void SetContinuationPreservedEmbedderData(Local<Value> data);
982982

983983
/**

0 commit comments

Comments
 (0)