Skip to content

Commit d3a1fa0

Browse files
mtbrandyCommit bot
authored andcommitted
Stack buffer for builtin code generation too small in some cases.
With --debug-code specified, 8 KB is not sufficient to contain some of the builtins on PPC64. This path is relevant only when snapshots are off. [email protected], [email protected], [email protected] BUG= Review URL: https://codereview.chromium.org/1415463002 Cr-Commit-Position: refs/heads/master@{#31449}
1 parent c610c63 commit d3a1fa0

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/builtins.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2131,6 +2131,9 @@ void Builtins::SetUp(Isolate* isolate, bool create_heap_objects) {
21312131
#ifdef DEBUG
21322132
// We can generate a lot of debug code on Arm64.
21332133
const size_t buffer_size = 32*KB;
2134+
#elif V8_TARGET_ARCH_PPC64
2135+
// 8 KB is insufficient on PPC64 when FLAG_debug_code is on.
2136+
const size_t buffer_size = 10 * KB;
21342137
#else
21352138
const size_t buffer_size = 8*KB;
21362139
#endif

0 commit comments

Comments
 (0)