[compiler] Emit proper instruction on indirect write barrier

Dominik Inführ · V8 LUCI CQ · commit d2b19bac1fb7 · 2025-09-16T06:43:40.000-07:00
When skipping indirect write barriers, we need to emit kArchStoreIndirectSkippedWriteBarrier which triggers the right verification. Bug: 437096305, 445102886 Change-Id: Ib4f3161a78fea1b7ce605e44a9484acd0fd825ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6954306 Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#102524}
diff --git a/src/compiler/backend/arm64/instruction-selector-arm64.cc b/src/compiler/backend/arm64/instruction-selector-arm64.cc
@@ -1279,8 +1279,8 @@ void InstructionSelector::VisitStore(OpIndex node) {
              write_barrier_kind == kSkippedWriteBarrier);
       // In this case we need to add the IndirectPointerTag as additional input.
       code = write_barrier_kind == kSkippedWriteBarrier
-                 ? kArchStoreIndirectWithWriteBarrier
-                 : kArchStoreIndirectSkippedWriteBarrier;
+                 ? kArchStoreIndirectSkippedWriteBarrier
+                 : kArchStoreIndirectWithWriteBarrier;
       code |= RecordWriteModeField::encode(
           RecordWriteMode::kValueIsIndirectPointer);
       IndirectPointerTag tag = store_view.indirect_pointer_tag();
diff --git a/src/compiler/backend/x64/instruction-selector-x64.cc b/src/compiler/backend/x64/instruction-selector-x64.cc
@@ -1478,8 +1478,8 @@ void VisitStoreCommon(InstructionSelector* selector,
              write_barrier_kind == kSkippedWriteBarrier);
       // In this case we need to add the IndirectPointerTag as additional input.
       code = write_barrier_kind == kSkippedWriteBarrier
-                 ? kArchStoreIndirectWithWriteBarrier
-                 : kArchStoreIndirectSkippedWriteBarrier;
+                 ? kArchStoreIndirectSkippedWriteBarrier
+                 : kArchStoreIndirectWithWriteBarrier;
       code |= RecordWriteModeField::encode(
           RecordWriteMode::kValueIsIndirectPointer);
       IndirectPointerTag tag = store.indirect_pointer_tag();
