Skip to content

Commit d0d5faa

Browse files
Takuto IkutaV8 LUCI CQ
authored andcommitted
mb: replace use_goma with use_remoteexec
This is preparation CL for https://crrev.com/c/4970657. Bug: b/306109834 Change-Id: I6b89ef515f542762a1426087047c1d4489526bbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4970736 Commit-Queue: Takuto Ikuta <[email protected]> Reviewed-by: Liviu Rau <[email protected]> Reviewed-by: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/heads/main@{#90550}
1 parent edd38bc commit d0d5faa

1 file changed

Lines changed: 17 additions & 21 deletions

File tree

infra/mb/mb_config.pyl

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@
580580
'release_x64_gcmole': [
581581
'release_bot', 'x64', 'gcmole'],
582582
'release_x64_msvc': [
583-
'release_bot_no_goma', 'x64', 'minimal_symbols', 'msvc'],
583+
'release_bot_no_reclient', 'x64', 'minimal_symbols', 'msvc'],
584584
'release_x64_correctness_fuzzer' : [
585585
'release_bot', 'x64', 'v8_correctness_fuzzer'],
586586
'release_x64_disable_runtime_call_stats': [
@@ -590,7 +590,7 @@
590590
'release_x64_fuchsia_trybot': [
591591
'release_trybot', 'x64', 'fuchsia'],
592592
'release_x64_gcc': [
593-
'release_bot_no_goma', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
593+
'release_bot_no_reclient', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
594594
'release_x64_ios_simulator': [
595595
'release_bot', 'x64', 'ios_simulator'],
596596
'release_x64_internal': [
@@ -649,7 +649,7 @@
649649
'debug_x64_asan': [
650650
'debug_bot', 'x64', 'asan', 'lsan'],
651651
'debug_x64_asan_no_lsan_static': [
652-
'debug', 'static', 'goma', 'v8_enable_slow_dchecks', 'v8_optimized_debug',
652+
'debug', 'static', 'reclient', 'v8_enable_slow_dchecks', 'v8_optimized_debug',
653653
'x64', 'asan'],
654654
'debug_x64_conservative_stack_scanning': [
655655
'debug_bot', 'x64', 'conservative_stack_scanning'],
@@ -662,7 +662,7 @@
662662
'debug_x64_fuchsia': [
663663
'debug_bot', 'x64', 'fuchsia'],
664664
'debug_x64_gcc': [
665-
'debug_bot_no_goma', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
665+
'debug_bot_no_reclient', 'x64', 'gcc', 'lld', 'no_custom_libcxx'],
666666
'debug_x64_header_includes': [
667667
'debug_bot', 'x64', 'v8_check_header_includes'],
668668
'debug_x64_no_shared_cage': [
@@ -697,15 +697,15 @@
697697
'debug_x86_minimal_symbols': [
698698
'debug_bot', 'x86', 'minimal_symbols'],
699699
'debug_x86_msvc': [
700-
'debug_bot_no_goma', 'x86', 'minimal_symbols', 'msvc'],
700+
'debug_bot_no_reclient', 'x86', 'minimal_symbols', 'msvc'],
701701
'debug_x86_no_i18n': [
702702
'debug_bot', 'x86', 'v8_no_i18n'],
703703
'debug_x86_trybot': [
704704
'debug_trybot', 'x86'],
705705
'debug_x86_vtunejit': [
706706
'debug_bot', 'x86', 'v8_enable_vtunejit'],
707707
'full_debug_x86': [
708-
'debug', 'x86', 'goma', 'v8_enable_slow_dchecks', 'v8_full_debug'],
708+
'debug', 'x86', 'reclient', 'v8_enable_slow_dchecks', 'v8_full_debug'],
709709

710710
# Release configs for x86.
711711
'release_x86': [
@@ -726,7 +726,7 @@
726726
'release_x64_predictable': [
727727
'release_bot', 'x64', 'v8_enable_verify_predictable'],
728728
'release_x86_shared_verify_heap': [
729-
'release', 'x86', 'goma', 'shared', 'v8_verify_heap'],
729+
'release', 'x86', 'reclient', 'shared', 'v8_verify_heap'],
730730
'release_x86_trybot': [
731731
'release_trybot', 'x86'],
732732
'release_x86_verify_csa': [
@@ -814,19 +814,19 @@
814814

815815
'debug_bot_no_slow_dchecks': {
816816
'mixins': [
817-
'debug', 'shared', 'goma', 'v8_disable_slow_dchecks',
817+
'debug', 'shared', 'reclient', 'v8_disable_slow_dchecks',
818818
'v8_optimized_debug', 'v8_enable_google_benchmark'],
819819
},
820820

821821
'debug_bot': {
822822
'mixins': [
823-
'debug', 'shared', 'goma', 'v8_enable_slow_dchecks',
823+
'debug', 'shared', 'reclient', 'v8_enable_slow_dchecks',
824824
'v8_optimized_debug', 'v8_enable_google_benchmark'],
825825
},
826826

827-
'debug_bot_no_goma': {
827+
'debug_bot_no_reclient': {
828828
'mixins': [
829-
'debug', 'shared', 'no_goma', 'v8_enable_slow_dchecks',
829+
'debug', 'shared', 'no_reclient', 'v8_enable_slow_dchecks',
830830
'v8_optimized_debug'],
831831
},
832832

@@ -868,10 +868,6 @@
868868
'gn_args': 'v8_gcmole=true',
869869
},
870870

871-
'goma': {
872-
'gn_args': 'use_goma=true',
873-
},
874-
875871
'hard_float': {
876872
'gn_args': 'arm_float_abi="hard"',
877873
},
@@ -911,8 +907,8 @@
911907
'gn_args': 'use_custom_libcxx=false',
912908
},
913909

914-
'no_goma': {
915-
'gn_args': 'use_goma=false',
910+
'no_reclient': {
911+
'gn_args': 'use_remoteexec=false',
916912
},
917913

918914
'no_sandbox': {
@@ -936,15 +932,15 @@
936932
},
937933

938934
'release_bot': {
939-
'mixins': ['release', 'static', 'goma', 'v8_enable_google_benchmark'],
935+
'mixins': ['release', 'static', 'reclient', 'v8_enable_google_benchmark'],
940936
},
941937

942-
'release_bot_no_goma': {
943-
'mixins': ['release', 'static', 'no_goma'],
938+
'release_bot_no_reclient': {
939+
'mixins': ['release', 'static', 'no_reclient'],
944940
},
945941

946942
'release_bot_reclient': {
947-
'mixins': ['release', 'static', 'no_goma', 'reclient'],
943+
'mixins': ['release', 'static', 'reclient'],
948944
},
949945

950946
'release_trybot': {

0 commit comments

Comments
 (0)