[parser] Add new FunctionNameInferrer state before parsing param

gsathya · Commit Bot · commit c3458a86722d · 2017-10-30T20:04:38.000Z
Create new state before parsing FormalParameter because we don't want to use any of the parameters as an inferred function name. Previously the stacktrace was: test.js:3: Error: boom throw new Error('boom'); ^ Error: boom at param (test.js:3:11) at test.js:4:5 at test.js:6:3 The stacktrace with this patch: test.js:3: Error: boom throw new Error('boom'); ^ Error: boom at test.js:3:11 at test.js:4:5 at test.js:6:3 Bug: v8:6822, v8:6513 Change-Id: Ifbadc660fc4e85248af405acd67c025f11662bd4 Reviewed-on: https://chromium-review.googlesource.com/742657 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#49042}
diff --git a/src/parsing/parser-base.h b/src/parsing/parser-base.h
@@ -3710,6 +3710,7 @@ void ParserBase<Impl>::ParseFormalParameter(FormalParametersT* parameters,
   //   BindingElement[?Yield, ?GeneratorParameter]
   bool is_rest = parameters->has_rest;
 
+  FuncNameInferrer::State fni_state(fni_);
   ExpressionT pattern = ParsePrimaryExpression(CHECK_OK_CUSTOM(Void));
   ValidateBindingPattern(CHECK_OK_CUSTOM(Void));
 
diff --git a/test/message/fail/func-name-inferrer-arg-1.js b/test/message/fail/func-name-inferrer-arg-1.js
@@ -0,0 +1,10 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+(function (param = function() { throw new Error('boom') }) {
+  (() => {
+    param();
+  })();
+
+})();
diff --git a/test/message/fail/func-name-inferrer-arg-1.out b/test/message/fail/func-name-inferrer-arg-1.out
@@ -0,0 +1,8 @@
+*%(basename)s:5: Error: boom
+(function (param = function() { throw new Error('boom') }) {
+                                ^
+Error: boom
+    at param (*%(basename)s:5:39)
+    at *%(basename)s:7:5
+    at *%(basename)s:8:5
+    at *%(basename)s:10:3
diff --git a/test/message/fail/func-name-inferrer-arg.js b/test/message/fail/func-name-inferrer-arg.js
@@ -0,0 +1,10 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+(function (param) {
+  (() => {
+    throw new Error('boom');
+  })();
+
+})();
diff --git a/test/message/fail/func-name-inferrer-arg.out b/test/message/fail/func-name-inferrer-arg.out
@@ -0,0 +1,7 @@
+*%(basename)s:7: Error: boom
+    throw new Error('boom');
+    ^
+Error: boom
+    at *%(basename)s:7:11
+    at *%(basename)s:8:5
+    at *%(basename)s:10:3
