PPC: [turbofan] Don't use the CompareIC in JSGenericLowering.

mtbrandy · Commit bot · commit c1507e158780 · 2016-02-26T22:14:58.000Z
Port d00da47 Original commit message: The CompareICStub produces an untagged raw word value, which has to be translated to true or false manually in the TurboFan code. But for lazy bailout after the CompareIC, we immediately go back to fullcodegen or Ignition with the raw value, to a location where both fullcodegen and Ignition expect a boolean value, which might crash or in the worst case (depending on the exact computation inside the CompareIC) could lead to arbitrary memory access. Short-term fix is to use the proper runtime functions (unified with the interpreter now) for comparisons. Next task is to provide optimized versions of these based on the CodeStubAssembler, which can then be used via code stubs in TurboFan or directly in handlers in the interpreter. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4788 LOG=n Review URL: https://codereview.chromium.org/1745643002 Cr-Commit-Position: refs/heads/master@{#34341}
diff --git a/src/ppc/code-stubs-ppc.cc b/src/ppc/code-stubs-ppc.cc
@@ -702,7 +702,7 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {
     {
       FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
       __ Push(lhs, rhs);
-      __ CallRuntime(strict() ? Runtime::kStrictEquals : Runtime::kEquals);
+      __ CallRuntime(strict() ? Runtime::kStrictEqual : Runtime::kEqual);
     }
     // Turn true into 0 and false into some non-zero value.
     STATIC_ASSERT(EQUAL == 0);

Original file line number	Diff line number	Diff line change
`@@ -702,7 +702,7 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {`
`702`	`702`	`{`
`703`	`703`	`FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);`
`704`	`704`	`__ Push(lhs, rhs);`
`705`		`- __ CallRuntime(strict() ? Runtime::kStrictEquals : Runtime::kEquals);`
	`705`	`+ __ CallRuntime(strict() ? Runtime::kStrictEqual : Runtime::kEqual);`
`706`	`706`	`}`
`707`	`707`	`// Turn true into 0 and false into some non-zero value.`
`708`	`708`	`STATIC_ASSERT(EQUAL == 0);`