Reland "[wasm] Enable wasm threads by default in V8"

dtig · Commit Bot · commit be9ff65a0696 · 2021-04-15T16:54:40.000Z
This is a reland of 6ec52d9. The failing tests have been adapted at the blink side. Original change's description: > [wasm] Enable wasm threads by default in V8 > > Finer grained control of platforms that support threads are > enforced by chromium. > > Bug: chromium:1167733 > Change-Id: Ic34a4950aebf6ba394053b79df97b703af333636 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810190 > Reviewed-by: Lutz Vahl <vahl@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73919} Bug: chromium:1167733 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Change-Id: I56a00a24f17fef8a8050ee6f4b28fc13c7d3fb30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826540 Reviewed-by: Lutz Vahl <vahl@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73981}
diff --git a/src/wasm/wasm-feature-flags.h b/src/wasm/wasm-feature-flags.h
@@ -66,14 +66,6 @@
   /* Staged in v8.7 * */                                                       \
   V(return_call, "return call opcodes", false)                                 \
                                                                                \
-  /* Threads proposal. */                                                      \
-  /* https://github.com/webassembly/threads */                                 \
-  /* NOTE: This is enabled via chromium flag on desktop systems since v7.4  */ \
-  /* (see https://crrev.com/c/1487808). ITS: https://groups.google.com/a/   */ \
-  /* chromium.org/d/msg/blink-dev/tD6np-OG2PU/rcNGROOMFQAJ */                  \
-  /* V8 side owner: gdeepti */                                                 \
-  V(threads, "thread opcodes", false)                                          \
-                                                                               \
   /* Type reflection proposal. */                                              \
   /* https://github.com/webassembly/js-types */                                \
   /* V8 side owner: ahaas */                                                   \
@@ -89,8 +81,19 @@
   /* V8 side owner: gdeepti, zhin */                                           \
   /* Staged in v8.7 * */                                                       \
   /* Shipped in v9.1 * */                                                      \
-  V(simd, "SIMD opcodes", true)
-
+  V(simd, "SIMD opcodes", true)                                                \
+                                                                               \
+  /* Threads proposal. */                                                      \
+  /* https://github.com/webassembly/threads */                                 \
+  /* NOTE: This is enabled via chromium flag on desktop systems since v7.4, */ \
+  /* and on android from 9.1. Threads are only available when */               \
+  /* SharedArrayBuffers are enabled as well, and are gated by COOP/COEP */     \
+  /* headers, more fine grained control is in the chromium codebase */         \
+  /* ITS: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ */         \
+  /* tD6np-OG2PU/rcNGROOMFQAJ */                                               \
+  /* V8 side owner: gdeepti */                                                 \
+  V(threads, "thread opcodes", true)                                           \
+                                                                               \
 // Combination of all available wasm feature flags.
 #define FOREACH_WASM_FEATURE_FLAG(V)        \
   FOREACH_WASM_EXPERIMENTAL_FEATURE_FLAG(V) \
