[intl] Fix {minute: '2-digit'}

FrankYFTang · V8 LUCI CQ · commit b6154439ef71 · 2024-06-24T20:21:16.000Z
Set the correct ICU option flag to respect all field length for pattern matching. Fixed: 40855035 Change-Id: I4b89301e4ad98e3db97708a309d11823da8c026f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5646178 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#94613}
diff --git a/src/objects/js-date-time-format.cc b/src/objects/js-date-time-format.cc
@@ -1847,7 +1847,7 @@ std::unique_ptr<icu::SimpleDateFormat> CreateICUDateFormat(
   // has to be discussed. Revisit once the spec is clarified/revised.
   icu::UnicodeString pattern;
   UErrorCode status = U_ZERO_ERROR;
-  pattern = generator->getBestPattern(skeleton, UDATPG_MATCH_HOUR_FIELD_LENGTH,
+  pattern = generator->getBestPattern(skeleton, UDATPG_MATCH_ALL_FIELDS_LENGTH,
                                       status);
   pattern = ReplaceHourCycleInPattern(pattern, hc);
   DCHECK(U_SUCCESS(status));
diff --git a/test/intl/regress-40855035.js b/test/intl/regress-40855035.js
@@ -0,0 +1,6 @@
+// Copyright 2024 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const formatter = new Intl.DateTimeFormat('en-us',{minute: '2-digit'})
+assertEquals("02", formatter.format(new Date(2024, 6, 21, 3, 2, 0)));
