Ignore --predictable when computing flag list hashes

joyeecheung · V8 LUCI CQ · commit b33bf2dfd261 · 2023-07-14T14:20:08.000Z
This allows reproducible code cache generation. Refs: nodejs/node#48749 Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#88943}
diff --git a/src/flags/flags.cc b/src/flags/flags.cc
@@ -539,8 +539,10 @@ uint32_t ComputeFlagListHash() {
     // We want to be able to flip --profile-deserialization without
     // causing the code cache to get invalidated by this hash.
     if (flag.PointsTo(&v8_flags.profile_deserialization)) continue;
-    // Skip v8_flags.random_seed to allow predictable code caching.
+    // Skip v8_flags.random_seed and v8_flags.predictable to allow predictable
+    // code caching.
     if (flag.PointsTo(&v8_flags.random_seed)) continue;
+    if (flag.PointsTo(&v8_flags.predictable)) continue;
     modified_args_as_string << flag;
   }
   std::string args(modified_args_as_string.str());
