[wasm] Check for access checks in InstallConditionalFeatures

gahaas · V8 LUCI CQ · commit b321e27267d3 · 2024-04-15T14:57:32.000Z
R=jkummerow@chromium.org Together-with: jkummerow@chromium.org Bug: 333926321 Change-Id: Ib319f64ac08e8081ffea49dae3a395a65c4b5db2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5445557 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#93369}
diff --git a/src/wasm/wasm-js.cc b/src/wasm/wasm-js.cc
@@ -3379,6 +3379,7 @@ void WasmJs::InstallConditionalFeatures(Isolate* isolate,
   if (!maybe_wasm.ToHandle(&wasm_obj) || !IsJSObject(*wasm_obj)) return;
   Handle<JSObject> webassembly = Handle<JSObject>::cast(wasm_obj);
   if (!webassembly->map()->is_extensible()) return;
+  if (webassembly->map()->is_access_check_needed()) return;
 
   /*
     If you need to install some optional features, follow the pattern:
diff --git a/test/mjsunit/regress/regress-333926321.js b/test/mjsunit/regress/regress-333926321.js
@@ -0,0 +1,7 @@
+// Copyright 2024 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+d8.test.enableJSPI();
+this.WebAssembly = this;
+d8.test.installConditionalFeatures();
