Do not penalize performance when --harmony-species is off

littledan · Commit bot · commit b1ec4cb67b7c · 2016-04-26T19:12:31.000Z
This patch ensures that the species protector does not cause any slow paths to be taken when --harmony-species is off by refraining from writing to and reading from the protector when the flag is off. BUG=chromium:606207 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1918383002 Cr-Commit-Position: refs/heads/master@{#35800}
diff --git a/src/isolate.cc b/src/isolate.cc
@@ -2554,6 +2554,7 @@ bool Isolate::IsFastArrayConstructorPrototypeChainIntact() {
 }
 
 bool Isolate::IsArraySpeciesLookupChainIntact() {
+  if (!FLAG_harmony_species) return true;
   // Note: It would be nice to have debug checks to make sure that the
   // species protector is accurate, but this would be hard to do for most of
   // what the protector stands for:
@@ -2572,6 +2573,7 @@ bool Isolate::IsArraySpeciesLookupChainIntact() {
 }
 
 void Isolate::InvalidateArraySpeciesProtector() {
+  if (!FLAG_harmony_species) return;
   DCHECK(factory()->species_protector()->value()->IsSmi());
   DCHECK(IsArraySpeciesLookupChainIntact());
   PropertyCell::SetValueWithInvalidation(

Original file line number	Diff line number	Diff line change
`@@ -2554,6 +2554,7 @@ bool Isolate::IsFastArrayConstructorPrototypeChainIntact() {`
`2554`	`2554`	`}`
`2555`	`2555`
`2556`	`2556`	`bool Isolate::IsArraySpeciesLookupChainIntact() {`
	`2557`	`+ if (!FLAG_harmony_species) return true;`
`2557`	`2558`	`// Note: It would be nice to have debug checks to make sure that the`
`2558`	`2559`	`// species protector is accurate, but this would be hard to do for most of`
`2559`	`2560`	`// what the protector stands for:`
`@@ -2572,6 +2573,7 @@ bool Isolate::IsArraySpeciesLookupChainIntact() {`
`2572`	`2573`	`}`
`2573`	`2574`
`2574`	`2575`	`void Isolate::InvalidateArraySpeciesProtector() {`
	`2576`	`+ if (!FLAG_harmony_species) return;`
`2575`	`2577`	`DCHECK(factory()->species_protector()->value()->IsSmi());`
`2576`	`2578`	`DCHECK(IsArraySpeciesLookupChainIntact());`
`2577`	`2579`	`PropertyCell::SetValueWithInvalidation(`