Skip to content

Commit b0af309

Browse files
backesCommit Bot
authored andcommitted
[api] Remove deprecated wasm methods
These methods were deprecated in 7.0, now we can remove them. [email protected] Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I60badb378a055152bdd27aed67d11ddf74fce174 Reviewed-on: https://chromium-review.googlesource.com/1209283 Reviewed-by: Adam Klein <[email protected]> Commit-Queue: Clemens Hammacher <[email protected]> Cr-Commit-Position: refs/heads/master@{#55695}
1 parent ad832c4 commit b0af309

2 files changed

Lines changed: 0 additions & 32 deletions

File tree

include/v8.h

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4378,13 +4378,6 @@ class V8_EXPORT WasmCompiledModule : public Object {
43784378
public:
43794379
typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
43804380

4381-
// The COMMA macro allows us to use ',' inside of the V8_DEPRECATED macro.
4382-
#define COMMA ,
4383-
V8_DEPRECATED(
4384-
"Use BufferReference.",
4385-
typedef std::pair<const uint8_t * COMMA size_t> CallerOwnedBuffer);
4386-
#undef COMMA
4387-
43884381
/**
43894382
* A unowned reference to a byte buffer.
43904383
*/
@@ -4393,12 +4386,6 @@ class V8_EXPORT WasmCompiledModule : public Object {
43934386
size_t size;
43944387
BufferReference(const uint8_t* start, size_t size)
43954388
: start(start), size(size) {}
4396-
// Temporarily allow conversion to and from CallerOwnedBuffer.
4397-
V8_DEPRECATED(
4398-
"Use BufferReference directly.",
4399-
inline BufferReference(CallerOwnedBuffer)); // NOLINT(runtime/explicit)
4400-
V8_DEPRECATED("Use BufferReference directly.",
4401-
inline operator CallerOwnedBuffer());
44024389
};
44034390

44044391
/**
@@ -4445,8 +4432,6 @@ class V8_EXPORT WasmCompiledModule : public Object {
44454432
* Get the wasm-encoded bytes that were used to compile this module.
44464433
*/
44474434
BufferReference GetWasmWireBytesRef();
4448-
V8_DEPRECATED("Use GetWasmWireBytesRef version.",
4449-
Local<String> GetWasmWireBytes());
44504435

44514436
/**
44524437
* Serialize the compiled module. The serialized data does not include the
@@ -4479,15 +4464,6 @@ class V8_EXPORT WasmCompiledModule : public Object {
44794464
static void CheckCast(Value* obj);
44804465
};
44814466

4482-
// TODO(clemensh): Remove after M70 branch.
4483-
WasmCompiledModule::BufferReference::BufferReference(
4484-
WasmCompiledModule::CallerOwnedBuffer buf)
4485-
: BufferReference(buf.first, buf.second) {}
4486-
WasmCompiledModule::BufferReference::
4487-
operator WasmCompiledModule::CallerOwnedBuffer() {
4488-
return {start, size};
4489-
}
4490-
44914467
/**
44924468
* The V8 interface for WebAssembly streaming compilation. When streaming
44934469
* compilation is initiated, V8 passes a {WasmStreaming} object to the embedder

src/api.cc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7312,14 +7312,6 @@ WasmCompiledModule::BufferReference WasmCompiledModule::GetWasmWireBytesRef() {
73127312
return {bytes_vec.start(), bytes_vec.size()};
73137313
}
73147314

7315-
Local<String> WasmCompiledModule::GetWasmWireBytes() {
7316-
BufferReference ref = GetWasmWireBytesRef();
7317-
CHECK_LE(ref.size, String::kMaxLength);
7318-
return String::NewFromOneByte(GetIsolate(), ref.start, NewStringType::kNormal,
7319-
static_cast<int>(ref.size))
7320-
.ToLocalChecked();
7321-
}
7322-
73237315
WasmCompiledModule::TransferrableModule
73247316
WasmCompiledModule::GetTransferrableModule() {
73257317
if (i::FLAG_wasm_shared_code) {

0 commit comments

Comments
 (0)