Skip to content

Commit ad2c5da

Browse files
achuithCommit Bot
achuith
authored and
Commit Bot
committed
Merged: [deoptimizer] Stricter checks during deoptimization
Revision: 506e893 BUG=chromium:1161357 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=​[email protected] (cherry picked from commit 44d052c) Change-Id: I97b69ae11d85bc0acd4a0c7bd28e1b692433de80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616219 Reviewed-by: Mythri Alle <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Original-Commit-Position: refs/branch-heads/8.8@{#23} Cr-Original-Branched-From: 2dbcdc1-refs/heads/8.8.278@{#1} Cr-Original-Branched-From: 366d30c-refs/heads/master@{#71094} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649571 Reviewed-by: Victor-Gabriel Savu <[email protected]> Commit-Queue: Achuith Bhandarkar <[email protected]> Cr-Commit-Position: refs/branch-heads/8.6@{#56} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
1 parent 482e5c7 commit ad2c5da

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

‎src/deoptimizer/deoptimizer.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ class ActivationsFinder : public ThreadVisitor {
282282
SafepointEntry safepoint = code.GetSafepointEntry(it.frame()->pc());
283283
int trampoline_pc = safepoint.trampoline_pc();
284284
DCHECK_IMPLIES(code == topmost_, safe_to_deopt_);
285+
CHECK_GE(trampoline_pc, 0);
285286
// Replace the current pc on the stack with the trampoline.
286287
// TODO(v8:10026): avoid replacing a signed pointer.
287288
Address* pc_addr = it.frame()->pc_address();

0 commit comments

Comments
 (0)