Skip to content

Commit a0d0c43

Browse files
indutnyCommit bot
authored andcommitted
tools: fix postmortem generator
BUG= R=danno Review URL: https://codereview.chromium.org/892223002 Cr-Commit-Position: refs/heads/master@{#26389}
1 parent d834db8 commit a0d0c43

3 files changed

Lines changed: 7 additions & 12 deletions

File tree

src/globals.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -567,9 +567,6 @@ struct AccessorDescriptor {
567567
#define HAS_SMI_TAG(value) \
568568
((reinterpret_cast<intptr_t>(value) & kSmiTagMask) == kSmiTag)
569569

570-
#define HAS_FAILURE_TAG(value) \
571-
((reinterpret_cast<intptr_t>(value) & kFailureTagMask) == kFailureTag)
572-
573570
// OBJECT_POINTER_ALIGN returns the value aligned as a HeapObject pointer
574571
#define OBJECT_POINTER_ALIGN(value) \
575572
(((value) + kObjectAlignmentMask) & ~kObjectAlignmentMask)

src/objects.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7071,6 +7071,8 @@ class SharedFunctionInfo: public HeapObject {
70717071
static const int kUniqueIdOffset = kFeedbackVectorOffset + kPointerSize;
70727072
static const int kLastPointerFieldOffset = kUniqueIdOffset;
70737073
#else
7074+
// Just to not break the postmortrem support with conditional offsets
7075+
static const int kUniqueIdOffset = kFeedbackVectorOffset;
70747076
static const int kLastPointerFieldOffset = kFeedbackVectorOffset;
70757077
#endif
70767078

tools/gen-postmortem-metadata.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@
7070
{ 'name': 'ExternalStringTag', 'value': 'kExternalStringTag' },
7171
{ 'name': 'SlicedStringTag', 'value': 'kSlicedStringTag' },
7272

73-
{ 'name': 'FailureTag', 'value': 'kFailureTag' },
74-
{ 'name': 'FailureTagMask', 'value': 'kFailureTagMask' },
7573
{ 'name': 'HeapObjectTag', 'value': 'kHeapObjectTag' },
7674
{ 'name': 'HeapObjectTagMask', 'value': 'kHeapObjectTagMask' },
7775
{ 'name': 'SmiTag', 'value': 'kSmiTag' },
@@ -94,8 +92,6 @@
9492
'value': 'DescriptorArray::kFirstIndex' },
9593
{ 'name': 'prop_type_field',
9694
'value': 'FIELD' },
97-
{ 'name': 'prop_type_first_phantom',
98-
'value': 'TRANSITION' },
9995
{ 'name': 'prop_type_mask',
10096
'value': 'PropertyDetails::TypeField::kMask' },
10197
{ 'name': 'prop_index_mask',
@@ -120,9 +116,9 @@
120116
'value': 'DICTIONARY_ELEMENTS' },
121117

122118
{ 'name': 'bit_field2_elements_kind_mask',
123-
'value': 'Map::kElementsKindMask' },
119+
'value': 'Map::ElementsKindBits::kMask' },
124120
{ 'name': 'bit_field2_elements_kind_shift',
125-
'value': 'Map::kElementsKindShift' },
121+
'value': 'Map::ElementsKindBits::kShift' },
126122
{ 'name': 'bit_field3_dictionary_map_shift',
127123
'value': 'Map::DictionaryMap::kShift' },
128124

@@ -196,9 +192,9 @@
196192
* This file is generated by %s. Do not edit directly.
197193
*/
198194
199-
#include "v8.h"
200-
#include "frames.h"
201-
#include "frames-inl.h" /* for architecture-specific frame constants */
195+
#include "src/v8.h"
196+
#include "src/frames.h"
197+
#include "src/frames-inl.h" /* for architecture-specific frame constants */
202198
203199
using namespace v8::internal;
204200

0 commit comments

Comments
 (0)