Don't assume all turbofan frames are JavaScript

Eric Leese · V8 LUCI CQ · commit 969cea30e86c · 2024-10-01T12:35:59.000Z
Bug: 367734947 Change-Id: I61ccc3b0d0c87bd0fc5b3aa03308897d6c472ce7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5898894 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Eric Leese <leese@chromium.org> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/main@{#96363}
diff --git a/src/execution/isolate.cc b/src/execution/isolate.cc
@@ -2675,6 +2675,13 @@ HandlerTable::CatchPrediction PredictExceptionFromBytecode(
 
 HandlerTable::CatchPrediction PredictException(const FrameSummary& summary,
                                                Isolate* isolate) {
+  if (!summary.IsJavaScript()) {
+    // This can happen when WASM is inlined by TurboFan. For now we ignore
+    // frames that are not JavaScript.
+    // TODO(https://crbug.com/349588762): We should also check Wasm code
+    // for exception handling.
+    return HandlerTable::UNCAUGHT;
+  }
   PtrComprCageBase cage_base(isolate);
   DirectHandle<AbstractCode> code = summary.AsJavaScript().abstract_code();
   if (code->kind(cage_base) == CodeKind::BUILTIN) {
