[profiler] sampled allocations should be marked as independent

ofrobots · Commit bot · commit 9622696b5e22 · 2016-05-04T09:59:41.000Z
Sampling heap profiler keeps weak references. These should be marked independent so that the weak callback can be dispatched on new space collections. BUG=v8:4959 LOG=N R=ulan@chromium.org Review-Url: https://codereview.chromium.org/1945193002 Cr-Commit-Position: refs/heads/master@{#36012}
diff --git a/src/profiler/sampling-heap-profiler.cc b/src/profiler/sampling-heap-profiler.cc
@@ -109,6 +109,7 @@ void SamplingHeapProfiler::SampleObject(Address soon_object, size_t size) {
   Sample* sample = new Sample(size, node, loc, this);
   samples_.insert(sample);
   sample->global.SetWeak(sample, OnWeakCallback, WeakCallbackType::kParameter);
+  sample->global.MarkIndependent();
 }
 
 void SamplingHeapProfiler::OnWeakCallback(

Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ void SamplingHeapProfiler::SampleObject(Address soon_object, size_t size) {`
`109`	`109`	`Sample* sample = new Sample(size, node, loc, this);`
`110`	`110`	`samples_.insert(sample);`
`111`	`111`	`sample->global.SetWeak(sample, OnWeakCallback, WeakCallbackType::kParameter);`
	`112`	`+ sample->global.MarkIndependent();`
`112`	`113`	`}`
`113`	`114`
`114`	`115`	`void SamplingHeapProfiler::OnWeakCallback(`