Skip to content

Commit 9521696

Browse files
Samuel GroßV8 LUCI CQ
Samuel Groß
authored and
V8 LUCI CQ
committed
[sandbox] Update test/mkgrokdump/README
When regenerating v8heapconst.py, the v8 sandbox now has to be enabled explicitly (using the v8_enabe_sandbox=true gn arg) as it is enabled by default in Chromium builds, but not standalone v8 builds. Bug: v8:13281 Change-Id: I1a0861b1d63f340465d7433e042b27eace706ca7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3895622 Commit-Queue: Adam Klein <[email protected]> Auto-Submit: Samuel Groß <[email protected]> Reviewed-by: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/main@{#83201}
1 parent 429f959 commit 9521696

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎test/mkgrokdump/README‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
If you change the heap layout, expect this test to fail (in CQ). You will then
2-
need to build x64 release and run `<outdir>/mkgrokdump > tools/v8heapconst.py`
3-
to rebaseline.
2+
need to build x64 release with v8_enable_sandbox=true and run
3+
`<outdir>/mkgrokdump > tools/v8heapconst.py` to rebaseline.
4+
The V8 sandbox has to be manually enabled as it is enabled by default only for
5+
Chromium builds, but not standalone v8 builds.

0 commit comments

Comments
 (0)