Skip to content

Commit 942c2ef

Browse files
schuayCommit Bot
authored andcommitted
[builtins] Remove builtins-call.cc
There's no builtin implementation code here, the two functions should live in builtins.cc. Change-Id: Ie3cff4f1a22c86984a99a3b5d1b82c0f9f9a1f5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2436458 Auto-Submit: Jakob Gruber <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/master@{#70196}
1 parent 44f23d6 commit 942c2ef

3 files changed

Lines changed: 24 additions & 40 deletions

File tree

BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2309,7 +2309,6 @@ v8_source_set("v8_base_without_compiler") {
23092309
"src/builtins/builtins-arraybuffer.cc",
23102310
"src/builtins/builtins-async-module.cc",
23112311
"src/builtins/builtins-bigint.cc",
2312-
"src/builtins/builtins-call.cc",
23132312
"src/builtins/builtins-callsite.cc",
23142313
"src/builtins/builtins-collections.cc",
23152314
"src/builtins/builtins-console.cc",

src/builtins/builtins-call.cc

Lines changed: 0 additions & 39 deletions
This file was deleted.

src/builtins/builtins.cc

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,30 @@ const char* Builtins::Lookup(Address pc) {
118118
return nullptr;
119119
}
120120

121+
Handle<Code> Builtins::CallFunction(ConvertReceiverMode mode) {
122+
switch (mode) {
123+
case ConvertReceiverMode::kNullOrUndefined:
124+
return builtin_handle(kCallFunction_ReceiverIsNullOrUndefined);
125+
case ConvertReceiverMode::kNotNullOrUndefined:
126+
return builtin_handle(kCallFunction_ReceiverIsNotNullOrUndefined);
127+
case ConvertReceiverMode::kAny:
128+
return builtin_handle(kCallFunction_ReceiverIsAny);
129+
}
130+
UNREACHABLE();
131+
}
132+
133+
Handle<Code> Builtins::Call(ConvertReceiverMode mode) {
134+
switch (mode) {
135+
case ConvertReceiverMode::kNullOrUndefined:
136+
return builtin_handle(kCall_ReceiverIsNullOrUndefined);
137+
case ConvertReceiverMode::kNotNullOrUndefined:
138+
return builtin_handle(kCall_ReceiverIsNotNullOrUndefined);
139+
case ConvertReceiverMode::kAny:
140+
return builtin_handle(kCall_ReceiverIsAny);
141+
}
142+
UNREACHABLE();
143+
}
144+
121145
Handle<Code> Builtins::NonPrimitiveToPrimitive(ToPrimitiveHint hint) {
122146
switch (hint) {
123147
case ToPrimitiveHint::kDefault:

0 commit comments

Comments
 (0)