Fix non-conforming braced-init-list in value_or()

joyeecheung · V8 LUCI CQ · commit 913f679d5a4a · 2026-04-09T06:30:17.000-07:00
value_or() is a function template that deduces its argument type. Passing a braced-init-list {} causes deduction to fail in GCC because {} has no type: wasm-shuffle-reducer.cc:576: error: no matching member function for call to 'value_or' note: candidate template ignored: couldn't infer template argument Clang only accepted it by chance. Replace {} with uint8_t{0} to make the type explicit. Refs: https://eel.is/c++draft/temp.deduct.call Refs: nodejs/node#62572 Change-Id: I589617c78fbc1a65a3475957f846ffb87364ff28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7726131 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#106357}
diff --git a/src/compiler/turboshaft/wasm-shuffle-reducer.cc b/src/compiler/turboshaft/wasm-shuffle-reducer.cc
@@ -573,7 +573,7 @@ void WasmShuffleAnalyzer::TryReduceFromMSB(OpIndex input,
     uint8_t index = shuffle.shuffle[i];
     if (index >= lower_limit && index <= upper_limit) {
       max = std::max(static_cast<uint8_t>(index % kSimd128Size),
-                     max.value_or({}));
+                     max.value_or(uint8_t{0}));
     }
   }
   if (max) {

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ void WasmShuffleAnalyzer::TryReduceFromMSB(OpIndex input,`
`573`	`573`	`uint8_t index = shuffle.shuffle[i];`
`574`	`574`	`if (index >= lower_limit && index <= upper_limit) {`
`575`	`575`	`max = std::max(static_cast<uint8_t>(index % kSimd128Size),`
`576`		`- max.value_or({}));`
	`576`	`+ max.value_or(uint8_t{0}));`
`577`	`577`	`}`
`578`	`578`	`}`
`579`	`579`	`if (max) {`