Repository navigation
Commit 853553f
[trace] Don't add 'new' to Wasm call site
When constructors builtins are inlined in Maglev, but the
constructor itself is not, we need to mark the call site
flag kIsConstructor. This allows the stack trace builder to add
the 'new' string.
However, this should not be done if the target is Wasm.
This creates the same stack trace string as Ignition.
Fixed: 450308355
Change-Id: I5c21eba3b46f97ddca9c51c21a66aa8169c0293c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7136920
Reviewed-by: Marja Hölttä <[email protected]>
Auto-Submit: Victor Gomes <[email protected]>
Commit-Queue: Victor Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#103617}1 parent 03eb882 commit 853553f
2 files changed
Lines changed: 44 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
892 | 892 | | |
893 | 893 | | |
894 | 894 | | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
895 | 898 | | |
896 | 899 | | |
897 | 900 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
0 commit comments