Skip to content

Commit 846f470

Browse files
mlippautzV8 LUCI CQ
authored andcommitted
third_party: Move vtune
- Move src/third_party/vtune to third_party/vtune Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit Bug: 383356859 Change-Id: I3be2beae2c4d572c1155ffb969ee77a777f10354 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6089296 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Leszek Swirski <[email protected]> Auto-Submit: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/main@{#97767}
1 parent b2f7c65 commit 846f470

18 files changed

Lines changed: 26 additions & 25 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
!/third_party/utf8-decoder
8787
!/third_party/v8
8888
!/third_party/valgrind
89+
!/third_party/vtune
8990
!/third_party/wasm-api
9091
/tools/builtins-pgo/profiles/*
9192
!/tools/builtins-pgo/profiles/.*

BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4416,9 +4416,9 @@ alias(
44164416
v8_library(
44174417
name = "v8_vtune",
44184418
srcs = [
4419-
"src/third_party/vtune/v8-vtune.h",
4420-
"src/third_party/vtune/vtune-jit.cc",
4421-
"src/third_party/vtune/vtune-jit.h",
4419+
"third_party/vtune/v8-vtune.h",
4420+
"third_party/vtune/vtune-jit.cc",
4421+
"third_party/vtune/vtune-jit.h",
44224422
],
44234423
copts = ["-I"],
44244424
deps = [

BUILD.gn

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6384,7 +6384,7 @@ v8_source_set("v8_base_without_compiler") {
63846384
"src/extensions/vtunedomain-support-extension.cc",
63856385
"src/extensions/vtunedomain-support-extension.h",
63866386
]
6387-
deps += [ "src/third_party/vtune:v8_vtune_trace_mark" ]
6387+
deps += [ "third_party/vtune:v8_vtune_trace_mark" ]
63886388
}
63896389
}
63906390

@@ -7293,7 +7293,7 @@ if (v8_enable_webassembly) {
72937293
"//build/win:default_exe_manifest",
72947294
]
72957295
if (v8_enable_vtunejit) {
7296-
deps += [ "src/third_party/vtune:v8_vtune" ]
7296+
deps += [ "third_party/vtune:v8_vtune" ]
72977297
}
72987298

72997299
# TODO: v8dll-main.cc equivalent for shared library builds
@@ -7797,7 +7797,7 @@ v8_executable("d8") {
77977797
defines = []
77987798

77997799
if (v8_enable_vtunejit) {
7800-
deps += [ "src/third_party/vtune:v8_vtune" ]
7800+
deps += [ "third_party/vtune:v8_vtune" ]
78017801
}
78027802
if (current_os == "zos" && is_component_build) {
78037803
deps += [ ":zoslib" ]

DEPS

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -509,12 +509,13 @@ include_rules = [
509509
# Everybody can use some things.
510510
'+include',
511511
'+unicode',
512-
'+third_party/fdlibm',
513-
'+third_party/ittapi/include',
514512
'+third_party/fast_float/src/include',
513+
'+third_party/fdlibm',
515514
'+third_party/fp16/src/include',
516-
'+third_party/v8/codegen',
517515
'+third_party/fuzztest',
516+
'+third_party/ittapi/include',
517+
'+third_party/v8/codegen',
518+
'+third_party/vtune',
518519
'+hwy/highway.h',
519520
# Abseil features are allow-listed. Please use your best judgement when adding
520521
# to this set -- if in doubt, email v8-dev@. For general guidance, refer to

src/d8/d8.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include <vector>
2020

2121
#ifdef ENABLE_VTUNE_JIT_INTERFACE
22-
#include "src/third_party/vtune/v8-vtune.h"
22+
#include "third_party/vtune/v8-vtune.h"
2323
#endif
2424

2525
#include "include/libplatform/libplatform.h"

src/extensions/vtunedomain-support-extension.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "include/v8-extension.h"
99
#include "src/base/strings.h"
1010
#include "src/base/vector.h"
11-
#include "src/third_party/vtune/vtuneapi.h"
11+
#include "third_party/vtune/vtuneapi.h"
1212

1313
#define UNKNOWN_PARAMS 1 << 0
1414
#define NO_DOMAIN_NAME 1 << 1

src/third_party/vtune/DEPS

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/third_party/vtune/OWNERS

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/wasm/c-api.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
#include "src/wasm/wasm-serialization.h"
4646
#include "third_party/wasm-api/wasm.h"
4747
#ifdef ENABLE_VTUNE_JIT_INTERFACE
48-
#include "src/third_party/vtune/v8-vtune.h"
48+
#include "third_party/vtune/v8-vtune.h"
4949
#endif
5050

5151
#ifdef WASM_API_DEBUG
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Use of this source code is governed by a BSD-style license that can be
33
# found in the LICENSE file.
44

5-
import("../../../gni/v8.gni")
5+
import("../../gni/v8.gni")
66
config("vtune_ittapi") {
77
include_dirs = [
88
"//third_party/ittapi/include",
@@ -21,7 +21,7 @@ v8_source_set("v8_vtune") {
2121
"vtune-jit.h",
2222
]
2323
configs = [ ":vtune_ittapi" ]
24-
deps = [ "../../..:v8" ]
24+
deps = [ "../..:v8" ]
2525
}
2626

2727
v8_source_set("v8_vtune_trace_mark") {

0 commit comments

Comments
 (0)