Reland "[iterator-helpers] Ship iterator helpers"

rmahdav · V8 LUCI CQ · commit 80fb7673eb2d · 2024-01-05T01:00:52.000Z
This is a reland of commit ee03a51 Two web tests are changed and temporarily skipped to be able to ship iterator helpers. These tests will be re-enabled after shipping this feature. https://chromium-review.googlesource.com/c/chromium/src/+/5170312 Original change's description: > [iterator-helpers] Ship iterator helpers > > This CL ship iterator helpers. > > Bug: v8:13558 > Change-Id: I24695b1664314e80ac6625183c8053330d0b0206 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5119127 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#91646} Bug: v8:13558 Change-Id: Id868b005efa78b9d1356c3e008989e9049756d7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5171905 Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#91685}
diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h
@@ -273,9 +273,7 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
 #endif
 
 // Features that are complete (but still behind the --harmony flag).
-#define HARMONY_STAGED_BASE(V)                  \
-  V(harmony_set_methods, "harmony Set Methods") \
-  V(harmony_iterator_helpers, "JavaScript iterator helpers")
+#define HARMONY_STAGED_BASE(V) V(harmony_set_methods, "harmony Set Methods")
 
 #define JAVASCRIPT_STAGED_FEATURES_BASE(V) \
   V(js_regexp_modifiers, "RegExp modifiers")
@@ -299,7 +297,8 @@ DEFINE_WEAK_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab)
   V(harmony_json_parse_with_source, "harmony json parse with source") \
   V(harmony_rab_gsab_transfer, "harmony ArrayBuffer.transfer")        \
   V(harmony_array_grouping, "harmony array grouping")                 \
-  V(harmony_array_from_async, "harmony Array.fromAsync")
+  V(harmony_array_from_async, "harmony Array.fromAsync")              \
+  V(harmony_iterator_helpers, "JavaScript iterator helpers")
 
 #define JAVASCRIPT_SHIPPING_FEATURES_BASE(V) \
   V(js_promise_withresolvers, "Promise.withResolvers")
diff --git a/test/mozilla/mozilla.status b/test/mozilla/mozilla.status
@@ -546,7 +546,6 @@
 
   # Uses Mozilla-specific QName, XML, XMLList and Iterator.
   'js1_5/Regress/regress-407323': [FAIL_OK],
-  'js1_5/Regress/regress-407957': [FAIL_OK],
 
 
   # Relies on JavaScript 1.2 / 1.3 deprecated features.
