[inspector] Generate custom previews in the objects creation context.

bmeurer · Commit Bot · commit 7dad47c69303 · 2019-08-30T10:50:40.000Z
Generating custom previews can invoke user specified JavaScript (via the `window.devtoolsFormatters` custom formatters feature). These custom formatters were previously invoked in the main page context, even for objects coming from other `<iframe>`s. Instead of using the main renderer context, we should instead generate the custom preview in the creation context of the object. Bug: chromium:997925 Change-Id: Ia07915cff6680153b6727e68117ed565e60bc1c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776093 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#63476}
diff --git a/src/inspector/custom-preview.cc b/src/inspector/custom-preview.cc
@@ -242,10 +242,10 @@ void bodyCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
 }  // anonymous namespace
 
 void generateCustomPreview(int sessionId, const String16& groupName,
-                           v8::Local<v8::Context> context,
                            v8::Local<v8::Object> object,
                            v8::MaybeLocal<v8::Value> maybeConfig, int maxDepth,
                            std::unique_ptr<CustomPreview>* preview) {
+  v8::Local<v8::Context> context = object->CreationContext();
   v8::Isolate* isolate = context->GetIsolate();
   v8::MicrotasksScope microtasksScope(isolate,
                                       v8::MicrotasksScope::kDoNotRunMicrotasks);
diff --git a/src/inspector/custom-preview.h b/src/inspector/custom-preview.h
@@ -13,9 +13,9 @@ namespace v8_inspector {
 const int kMaxCustomPreviewDepth = 20;
 
 void generateCustomPreview(
-    int sessionId, const String16& groupName, v8::Local<v8::Context> context,
-    v8::Local<v8::Object> object, v8::MaybeLocal<v8::Value> config,
-    int maxDepth, std::unique_ptr<protocol::Runtime::CustomPreview>* preview);
+    int sessionId, const String16& groupName, v8::Local<v8::Object> object,
+    v8::MaybeLocal<v8::Value> config, int maxDepth,
+    std::unique_ptr<protocol::Runtime::CustomPreview>* preview);
 
 }  // namespace v8_inspector
 
diff --git a/src/inspector/injected-script.cc b/src/inspector/injected-script.cc
@@ -462,7 +462,7 @@ Response InjectedScript::wrapObjectMirror(
   if (!response.isSuccess()) return response;
   if (customPreviewEnabled && value->IsObject()) {
     std::unique_ptr<protocol::Runtime::CustomPreview> customPreview;
-    generateCustomPreview(sessionId, groupName, context, value.As<v8::Object>(),
+    generateCustomPreview(sessionId, groupName, value.As<v8::Object>(),
                           customPreviewConfig, maxCustomPreviewDepth,
                           &customPreview);
     if (customPreview) (*result)->setCustomPreview(std::move(customPreview));
