[wasm-simd][liftoff] Check CpuFeatures for SIMD support

ngzhian · Commit Bot · commit 7c32fa05df69 · 2020-01-30T18:29:42.000Z
If Wasm simd128 is not supported on this particular hardware, we bail out to TurboFan. Bug: v8:9909 Change-Id: Ie46e154426783ba099b7c0facc906670cda1bdd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2029427 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66055}
diff --git a/src/wasm/baseline/liftoff-compiler.cc b/src/wasm/baseline/liftoff-compiler.cc
@@ -357,6 +357,11 @@ class LiftoffCompiler {
   bool CheckSupportedType(FullDecoder* decoder,
                           Vector<const ValueType> supported_types,
                           ValueType type, const char* context) {
+    // Special case for kWasm128 which requires specific hardware support.
+    if (type == kWasmS128 && (!CpuFeatures::SupportsWasmSimd128())) {
+      unsupported(decoder, kSimd, "simd");
+      return false;
+    }
     // Check supported types.
     for (ValueType supported : supported_types) {
       if (type == supported) return true;
@@ -2198,6 +2203,9 @@ class LiftoffCompiler {
 
   void SimdOp(FullDecoder* decoder, WasmOpcode opcode, Vector<Value> args,
               Value* result) {
+    if (!CpuFeatures::SupportsWasmSimd128()) {
+      return unsupported(decoder, kSimd, "simd");
+    }
     switch (opcode) {
       case wasm::kExprF32x4Splat:
         EmitUnOp<kWasmF32, kWasmS128>(
