[wasm] Skip WasmJSFunctions in js-to-wasm wrapper tier-up

thibaudmichaud · V8 LUCI CQ · commit 7860c9605e30 · 2024-08-29T13:49:06.000Z
When a js-to-wasm wrapper tiers up, we also set the newly compiled wrapper as the target for other exports that have the same signature. This assumed that all exports have type WasmExportedFunction, but they can also have type WasmJSFunction in the case of a re-exported WebAssembly.Function import. R=clemensb@chromium.org Fixed: 362539773 Change-Id: I190a680ac5726122e2124977668bba3a95df93b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5822928 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#95877}
diff --git a/src/runtime/runtime-wasm.cc b/src/runtime/runtime-wasm.cc
@@ -547,6 +547,8 @@ void ReplaceJSToWasmWrapper(
   CHECK(trusted_instance_data->try_get_func_ref(function_index, &func_ref));
   Tagged<JSFunction> external_function;
   CHECK(func_ref->internal(isolate)->try_get_external(&external_function));
+  if (external_function->shared()->HasWasmJSFunctionData()) return;
+  CHECK(external_function->shared()->HasWasmExportedFunctionData());
   external_function->UpdateCode(*wrapper_code);
   Tagged<WasmExportedFunctionData> function_data =
       external_function->shared()->wasm_exported_function_data();
