[wasm][fuzzer] add missing comparison of stringrefs to differential fuzzing

Nikolas Kaipel · V8 LUCI CQ · commit 6f1b6b6f93e2 · 2025-09-10T05:24:15.000-07:00
The comparison of global variable values for the differential fuzzing was missing a comparison for string refs. Bug: 443362696 Change-Id: I20c86807777995372c827f13206725e5c48cb684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6934785 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Nikolas Kaipel <nikolaskaipel@google.com> Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#102379}
diff --git a/test/fuzzer/wasm/fuzzer-common.cc b/test/fuzzer/wasm/fuzzer-common.cc
@@ -210,13 +210,18 @@ bool ValuesEquivalent(const WasmValue& init_lhs, const WasmValue& init_rhs,
           case HeapType::kEq:
           case HeapType::kArray:
           case HeapType::kStruct:
+          case HeapType::kString:
             if (IsNull(lhs_ref) || IsWasmNull(lhs_ref)) break;
             if (IsWasmStruct(lhs_ref)) {
               if (!CheckStruct(lhs_ref, rhs_ref)) return false;
             } else if (IsWasmArray(lhs_ref)) {
               if (!CheckArray(lhs_ref, rhs_ref)) return false;
             } else if (IsSmi(lhs_ref)) {
               if (lhs_ref != rhs_ref) return false;
+            } else if (IsString(lhs_ref)) {
+              Tagged<String> lhs_str = Cast<String>(lhs_ref);
+              Tagged<String> rhs_str = Cast<String>(rhs_ref);
+              if (!lhs_str->Equals(rhs_str)) return false;
             }
             break;
           default:
