Skip to content

Commit 6eff00a

Browse files
joyeecheungV8 LUCI CQ
authored andcommitted
[runtime] zero-initialize descriptor array padding
So that snapshot and code cache stay reproducible. See nodejs/node-v8#304 Change-Id: Ic30970097ab46a26fa5bcf0f73e0fe62089890cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7271645 Reviewed-by: Patrick Thier <[email protected]> Commit-Queue: Joyee Cheung <[email protected]> Cr-Commit-Position: refs/heads/main@{#104436}
1 parent 75d1ff2 commit 6eff00a

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/objects/objects.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3996,6 +3996,9 @@ void DescriptorArray::Initialize(Tagged<EnumCache> empty_enum_cache,
39963996
set_enum_cache(empty_enum_cache, SKIP_WRITE_BARRIER);
39973997
set_flags(FastIterableBits::encode(FastIterableState::kUnknown),
39983998
kRelaxedStore);
3999+
#if TAGGED_SIZE_8_BYTES
4000+
set_optional_padding(0);
4001+
#endif
39994002
MemsetTagged(GetDescriptorSlot(0), undefined_value,
40004003
number_of_all_descriptors() * kEntrySize);
40014004
}

0 commit comments

Comments
 (0)