[debug] allow JS execution in ProcessCompileEvent callbacks

addaleax · Commit Bot · commit 6751db26ac8a · 2017-10-10T11:02:50.000Z
In Debug mode, V8 disallows executing JavaScript during `ScriptCompiler::CompileUnbound()` calls. This restriction makes sense during compilation, but not really for the post-compile notification, and currently at least one Node.js test (`test/inspector/test-contexts.js`) fails because of this in debug mode. Bug: Change-Id: I930b5f06083c0e87f1613414da3dfe2bcdf0f386 Reviewed-on: https://chromium-review.googlesource.com/706943 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48421}
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
@@ -1886,6 +1886,7 @@ void Debug::ProcessCompileEvent(v8::DebugEvent event, Handle<Script> script) {
   HandleScope scope(isolate_);
   PostponeInterruptsScope postpone(isolate_);
   DisableBreak no_recursive_break(this);
+  AllowJavascriptExecution allow_script(isolate_);
   debug_delegate_->ScriptCompiled(ToApiHandle<debug::Script>(script),
                                   live_edit_enabled(),
                                   event != v8::AfterCompile);
