Fix integer multiplication in parser ablation

o- · V8 LUCI CQ · commit 6624c237b903 · 2025-10-27T03:18:12.000-07:00
base::TimeDelta implements only integer operators. Bug: 430201172 Change-Id: I1bf3b86f250a846ed27457f2827bfe729a3d8f10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7080233 Auto-Submit: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#103356}
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
@@ -212,7 +212,9 @@ InterpreterCompilationJob::Status InterpreterCompilationJob::ExecuteJobImpl() {
   if (timer && timer->Elapsed().InNanoseconds() > 0) {
     auto end = timer->Elapsed();
     end += std::min(base::TimeDelta::FromSeconds(1),
-                    end * v8_flags.bytecode_compiler_ablation_amount);
+                    base::TimeDelta::FromMicroseconds(
+                        static_cast<double>(end.InMicroseconds()) *
+                        v8_flags.bytecode_compiler_ablation_amount));
     while (timer->Elapsed() < end) {
     }
   }
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
@@ -863,7 +863,9 @@ FunctionLiteral* Parser::DoParseProgram(Isolate* isolate, ParseInfo* info) {
   if (timer && timer->Elapsed().InNanoseconds() > 0) {
     auto end = timer->Elapsed();
     end += std::min(base::TimeDelta::FromSeconds(1),
-                    end * v8_flags.parser_ablation_amount);
+                    base::TimeDelta::FromMicroseconds(
+                        static_cast<double>(end.InMicroseconds()) *
+                        v8_flags.parser_ablation_amount));
     while (timer->Elapsed() < end) {
     }
   }
@@ -1230,7 +1232,9 @@ FunctionLiteral* Parser::DoParseFunction(Isolate* isolate, ParseInfo* info,
   if (timer && timer->Elapsed().InNanoseconds() > 0) {
     auto end = timer->Elapsed();
     end += std::min(base::TimeDelta::FromSeconds(1),
-                    end * v8_flags.parser_ablation_amount);
+                    base::TimeDelta::FromMicroseconds(
+                        static_cast<double>(end.InMicroseconds()) *
+                        v8_flags.parser_ablation_amount));
     while (timer->Elapsed() < end) {
     }
   }
@@ -3025,7 +3029,9 @@ bool Parser::SkipFunction(const AstRawString* function_name, FunctionKind kind,
   if (timer && timer->Elapsed().InNanoseconds() > 0) {
     auto end = timer->Elapsed();
     end += std::min(base::TimeDelta::FromSeconds(1),
-                    end * v8_flags.preparser_ablation_amount);
+                    base::TimeDelta::FromMicroseconds(
+                        static_cast<double>(end.InMicroseconds()) *
+                        v8_flags.preparser_ablation_amount));
     while (timer->Elapsed() < end) {
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,9 @@ InterpreterCompilationJob::Status InterpreterCompilationJob::ExecuteJobImpl() {`
`212`	`212`	`if (timer && timer->Elapsed().InNanoseconds() > 0) {`
`213`	`213`	`auto end = timer->Elapsed();`
`214`	`214`	`end += std::min(base::TimeDelta::FromSeconds(1),`
`215`		`- end * v8_flags.bytecode_compiler_ablation_amount);`
	`215`	`+ base::TimeDelta::FromMicroseconds(`
	`216`	`+ static_cast<double>(end.InMicroseconds()) *`
	`217`	`+ v8_flags.bytecode_compiler_ablation_amount));`
`216`	`218`	`while (timer->Elapsed() < end) {`
`217`	`219`	`}`
`218`	`220`	`}`
Original file line number	Diff line number	Diff line change
`@@ -863,7 +863,9 @@ FunctionLiteral* Parser::DoParseProgram(Isolate* isolate, ParseInfo* info) {`
`863`	`863`	`if (timer && timer->Elapsed().InNanoseconds() > 0) {`
`864`	`864`	`auto end = timer->Elapsed();`
`865`	`865`	`end += std::min(base::TimeDelta::FromSeconds(1),`
`866`		`- end * v8_flags.parser_ablation_amount);`
	`866`	`+ base::TimeDelta::FromMicroseconds(`
	`867`	`+ static_cast<double>(end.InMicroseconds()) *`
	`868`	`+ v8_flags.parser_ablation_amount));`
`867`	`869`	`while (timer->Elapsed() < end) {`
`868`	`870`	`}`
`869`	`871`	`}`
`@@ -1230,7 +1232,9 @@ FunctionLiteral* Parser::DoParseFunction(Isolate* isolate, ParseInfo* info,`
`1230`	`1232`	`if (timer && timer->Elapsed().InNanoseconds() > 0) {`
`1231`	`1233`	`auto end = timer->Elapsed();`
`1232`	`1234`	`end += std::min(base::TimeDelta::FromSeconds(1),`
`1233`		`- end * v8_flags.parser_ablation_amount);`
	`1235`	`+ base::TimeDelta::FromMicroseconds(`
	`1236`	`+ static_cast<double>(end.InMicroseconds()) *`
	`1237`	`+ v8_flags.parser_ablation_amount));`
`1234`	`1238`	`while (timer->Elapsed() < end) {`
`1235`	`1239`	`}`
`1236`	`1240`	`}`
`@@ -3025,7 +3029,9 @@ bool Parser::SkipFunction(const AstRawString* function_name, FunctionKind kind,`
`3025`	`3029`	`if (timer && timer->Elapsed().InNanoseconds() > 0) {`
`3026`	`3030`	`auto end = timer->Elapsed();`
`3027`	`3031`	`end += std::min(base::TimeDelta::FromSeconds(1),`
`3028`		`- end * v8_flags.preparser_ablation_amount);`
	`3032`	`+ base::TimeDelta::FromMicroseconds(`
	`3033`	`+ static_cast<double>(end.InMicroseconds()) *`
	`3034`	`+ v8_flags.preparser_ablation_amount));`
`3029`	`3035`	`while (timer->Elapsed() < end) {`
`3030`	`3036`	`}`
`3031`	`3037`	`}`