Skip to content

Commit 61815a2

Browse files
sethbrenithCommit Bot
sethbrenith
authored and
Commit Bot
committed
Use consistent capitalization rules for instance types
In preparation for allowing Torque to generate the list of instance types, I'd like to make the rules a bit more consistent for how instance types are spelled. This CL is my proposal for a system where every non-String instance type name is exactly equal to calling CapifyStringWithUnderscores on the corresponding class name and appending "_TYPE". This change is almost all find&replace; the only manual changes are in: - src/objects/instance-type.h - src/torque/utils.cc - tools/gen-postmortem-metadata.py This change is in response to the review comment https://chromium-review.googlesource.com/c/v8/v8/+/1757094/25/src/builtins/base.tq#132 Change-Id: Ife3857292669f54931708e934398b2684e60bea5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1814888 Commit-Queue: Seth Brenith <[email protected]> Reviewed-by: Michael Starzinger <[email protected]> Reviewed-by: Tobias Tebbi <[email protected]> Reviewed-by: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#64199}
1 parent 566ba79 commit 61815a2

41 files changed

Lines changed: 364 additions & 360 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/builtins/builtins-intl-gen.cc‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,7 @@ void IntlBuiltinsAssembler::ListFormatCommon(TNode<Context> context,
158158

159159
// 3. If lf does not have an [[InitializedListFormat]] internal slot, throw a
160160
// TypeError exception.
161-
ThrowIfNotInstanceType(context, receiver, JS_INTL_LIST_FORMAT_TYPE,
162-
method_name);
161+
ThrowIfNotInstanceType(context, receiver, JS_LIST_FORMAT_TYPE, method_name);
163162
TNode<JSListFormat> list_format = CAST(receiver);
164163

165164
TNode<Object> list = args.GetOptionalArgumentValue(0);

‎src/builtins/builtins-object-gen.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -758,8 +758,8 @@ TF_BUILTIN(ObjectToString, ObjectBuiltinsAssembler) {
758758
} kJumpTable[] = {{JS_OBJECT_TYPE, &if_object},
759759
{JS_ARRAY_TYPE, &if_array},
760760
{JS_FUNCTION_TYPE, &if_function},
761-
{JS_REGEXP_TYPE, &if_regexp},
762-
{JS_ARGUMENTS_TYPE, &if_arguments},
761+
{JS_REG_EXP_TYPE, &if_regexp},
762+
{JS_ARGUMENTS_OBJECT_TYPE, &if_arguments},
763763
{JS_DATE_TYPE, &if_date},
764764
{JS_BOUND_FUNCTION_TYPE, &if_function},
765765
{JS_API_OBJECT_TYPE, &if_apiobject},

‎src/builtins/builtins-regexp-gen.cc‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ RegExpBuiltinsAssembler::RegExpPrototypeExecBodyWithoutResult(
744744
TNode<Context> context, TNode<JSReceiver> maybe_regexp,
745745
TNode<String> string, Label* if_didnotmatch, const bool is_fastpath) {
746746
if (!is_fastpath) {
747-
ThrowIfNotInstanceType(context, maybe_regexp, JS_REGEXP_TYPE,
747+
ThrowIfNotInstanceType(context, maybe_regexp, JS_REG_EXP_TYPE,
748748
"RegExp.prototype.exec");
749749
}
750750

@@ -949,7 +949,7 @@ TNode<BoolT> RegExpBuiltinsAssembler::IsFastRegExpWithOriginalExec(
949949
GotoIfForceSlowPath(&out);
950950
#endif
951951

952-
TNode<BoolT> is_regexp = HasInstanceType(object, JS_REGEXP_TYPE);
952+
TNode<BoolT> is_regexp = HasInstanceType(object, JS_REG_EXP_TYPE);
953953

954954
var_result = is_regexp;
955955
GotoIfNot(is_regexp, &out);
@@ -1446,7 +1446,7 @@ TF_BUILTIN(RegExpPrototypeCompile, RegExpBuiltinsAssembler) {
14461446
TNode<Object> maybe_flags = CAST(Parameter(Descriptor::kFlags));
14471447
TNode<Context> context = CAST(Parameter(Descriptor::kContext));
14481448

1449-
ThrowIfNotInstanceType(context, maybe_receiver, JS_REGEXP_TYPE,
1449+
ThrowIfNotInstanceType(context, maybe_receiver, JS_REG_EXP_TYPE,
14501450
"RegExp.prototype.compile");
14511451
const TNode<JSRegExp> receiver = CAST(maybe_receiver);
14521452

@@ -1591,7 +1591,7 @@ TNode<Object> RegExpBuiltinsAssembler::RegExpExec(
15911591

15921592
BIND(&if_isnotcallable);
15931593
{
1594-
ThrowIfNotInstanceType(context, maybe_regexp, JS_REGEXP_TYPE,
1594+
ThrowIfNotInstanceType(context, maybe_regexp, JS_REG_EXP_TYPE,
15951595
"RegExp.prototype.exec");
15961596

15971597
var_result = CallBuiltin(Builtins::kRegExpPrototypeExecSlow, context,

‎src/codegen/code-stub-assembler.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6302,7 +6302,7 @@ TNode<BoolT> CodeStubAssembler::IsJSStringIterator(
63026302

63036303
TNode<BoolT> CodeStubAssembler::IsJSRegExpStringIterator(
63046304
SloppyTNode<HeapObject> object) {
6305-
return HasInstanceType(object, JS_REGEXP_STRING_ITERATOR_TYPE);
6305+
return HasInstanceType(object, JS_REG_EXP_STRING_ITERATOR_TYPE);
63066306
}
63076307

63086308
TNode<BoolT> CodeStubAssembler::IsMap(SloppyTNode<HeapObject> map) {
@@ -6638,7 +6638,7 @@ TNode<BoolT> CodeStubAssembler::IsJSDataView(TNode<HeapObject> object) {
66386638
}
66396639

66406640
TNode<BoolT> CodeStubAssembler::IsJSRegExp(SloppyTNode<HeapObject> object) {
6641-
return HasInstanceType(object, JS_REGEXP_TYPE);
6641+
return HasInstanceType(object, JS_REG_EXP_TYPE);
66426642
}
66436643

66446644
TNode<BoolT> CodeStubAssembler::IsNumber(SloppyTNode<Object> object) {

‎src/compiler/js-call-reducer.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3705,7 +3705,7 @@ Reduction JSCallReducer::ReduceJSCall(Node* node,
37053705
case Builtins::kMapIteratorPrototypeNext:
37063706
return ReduceCollectionIteratorPrototypeNext(
37073707
node, OrderedHashMap::kEntrySize, factory()->empty_ordered_hash_map(),
3708-
FIRST_MAP_ITERATOR_TYPE, LAST_MAP_ITERATOR_TYPE);
3708+
FIRST_JS_MAP_ITERATOR_TYPE, LAST_JS_MAP_ITERATOR_TYPE);
37093709
case Builtins::kSetPrototypeEntries:
37103710
return ReduceCollectionIteration(node, CollectionKind::kSet,
37113711
IterationKind::kEntries);
@@ -3717,7 +3717,7 @@ Reduction JSCallReducer::ReduceJSCall(Node* node,
37173717
case Builtins::kSetIteratorPrototypeNext:
37183718
return ReduceCollectionIteratorPrototypeNext(
37193719
node, OrderedHashSet::kEntrySize, factory()->empty_ordered_hash_set(),
3720-
FIRST_SET_ITERATOR_TYPE, LAST_SET_ITERATOR_TYPE);
3720+
FIRST_JS_SET_ITERATOR_TYPE, LAST_JS_SET_ITERATOR_TYPE);
37213721
case Builtins::kDatePrototypeGetTime:
37223722
return ReduceDatePrototypeGetTime(node);
37233723
case Builtins::kDateNow:

‎src/compiler/types.cc‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ Type::bitset BitsetType::Lub(const MapRefLike& map) {
183183
case HEAP_NUMBER_TYPE:
184184
return kNumber;
185185
case JS_OBJECT_TYPE:
186-
case JS_ARGUMENTS_TYPE:
186+
case JS_ARGUMENTS_OBJECT_TYPE:
187187
case JS_ERROR_TYPE:
188188
case JS_GLOBAL_OBJECT_TYPE:
189189
case JS_GLOBAL_PROXY_TYPE:
@@ -207,16 +207,16 @@ Type::bitset BitsetType::Lub(const MapRefLike& map) {
207207
case JS_MESSAGE_OBJECT_TYPE:
208208
case JS_DATE_TYPE:
209209
#ifdef V8_INTL_SUPPORT
210-
case JS_INTL_V8_BREAK_ITERATOR_TYPE:
211-
case JS_INTL_COLLATOR_TYPE:
212-
case JS_INTL_DATE_TIME_FORMAT_TYPE:
213-
case JS_INTL_LIST_FORMAT_TYPE:
214-
case JS_INTL_LOCALE_TYPE:
215-
case JS_INTL_NUMBER_FORMAT_TYPE:
216-
case JS_INTL_PLURAL_RULES_TYPE:
217-
case JS_INTL_RELATIVE_TIME_FORMAT_TYPE:
218-
case JS_INTL_SEGMENT_ITERATOR_TYPE:
219-
case JS_INTL_SEGMENTER_TYPE:
210+
case JS_V8_BREAK_ITERATOR_TYPE:
211+
case JS_COLLATOR_TYPE:
212+
case JS_DATE_TIME_FORMAT_TYPE:
213+
case JS_LIST_FORMAT_TYPE:
214+
case JS_LOCALE_TYPE:
215+
case JS_NUMBER_FORMAT_TYPE:
216+
case JS_PLURAL_RULES_TYPE:
217+
case JS_RELATIVE_TIME_FORMAT_TYPE:
218+
case JS_SEGMENT_ITERATOR_TYPE:
219+
case JS_SEGMENTER_TYPE:
220220
#endif // V8_INTL_SUPPORT
221221
case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
222222
case JS_GENERATOR_OBJECT_TYPE:
@@ -225,8 +225,8 @@ Type::bitset BitsetType::Lub(const MapRefLike& map) {
225225
case JS_MODULE_NAMESPACE_TYPE:
226226
case JS_ARRAY_BUFFER_TYPE:
227227
case JS_ARRAY_ITERATOR_TYPE:
228-
case JS_REGEXP_TYPE: // TODO(rossberg): there should be a RegExp type.
229-
case JS_REGEXP_STRING_ITERATOR_TYPE:
228+
case JS_REG_EXP_TYPE:
229+
case JS_REG_EXP_STRING_ITERATOR_TYPE:
230230
case JS_TYPED_ARRAY_TYPE:
231231
case JS_DATA_VIEW_TYPE:
232232
case JS_SET_TYPE:
@@ -244,12 +244,12 @@ Type::bitset BitsetType::Lub(const MapRefLike& map) {
244244
case JS_WEAK_REF_TYPE:
245245
case JS_WEAK_SET_TYPE:
246246
case JS_PROMISE_TYPE:
247-
case WASM_EXCEPTION_TYPE:
248-
case WASM_GLOBAL_TYPE:
249-
case WASM_INSTANCE_TYPE:
250-
case WASM_MEMORY_TYPE:
251-
case WASM_MODULE_TYPE:
252-
case WASM_TABLE_TYPE:
247+
case WASM_EXCEPTION_OBJECT_TYPE:
248+
case WASM_GLOBAL_OBJECT_TYPE:
249+
case WASM_INSTANCE_OBJECT_TYPE:
250+
case WASM_MEMORY_OBJECT_TYPE:
251+
case WASM_MODULE_OBJECT_TYPE:
252+
case WASM_TABLE_OBJECT_TYPE:
253253
case WEAK_CELL_TYPE:
254254
DCHECK(!map.is_callable());
255255
DCHECK(!map.is_undetectable());

‎src/diagnostics/objects-debug.cc‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -259,25 +259,25 @@ void HeapObject::HeapObjectVerify(Isolate* isolate) {
259259
case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
260260
JSObject::cast(*this).JSObjectVerify(isolate);
261261
break;
262-
case WASM_MODULE_TYPE:
262+
case WASM_MODULE_OBJECT_TYPE:
263263
WasmModuleObject::cast(*this).WasmModuleObjectVerify(isolate);
264264
break;
265-
case WASM_TABLE_TYPE:
265+
case WASM_TABLE_OBJECT_TYPE:
266266
WasmTableObject::cast(*this).WasmTableObjectVerify(isolate);
267267
break;
268-
case WASM_MEMORY_TYPE:
268+
case WASM_MEMORY_OBJECT_TYPE:
269269
WasmMemoryObject::cast(*this).WasmMemoryObjectVerify(isolate);
270270
break;
271-
case WASM_GLOBAL_TYPE:
271+
case WASM_GLOBAL_OBJECT_TYPE:
272272
WasmGlobalObject::cast(*this).WasmGlobalObjectVerify(isolate);
273273
break;
274-
case WASM_EXCEPTION_TYPE:
274+
case WASM_EXCEPTION_OBJECT_TYPE:
275275
WasmExceptionObject::cast(*this).WasmExceptionObjectVerify(isolate);
276276
break;
277-
case WASM_INSTANCE_TYPE:
277+
case WASM_INSTANCE_OBJECT_TYPE:
278278
WasmInstanceObject::cast(*this).WasmInstanceObjectVerify(isolate);
279279
break;
280-
case JS_ARGUMENTS_TYPE:
280+
case JS_ARGUMENTS_OBJECT_TYPE:
281281
JSArgumentsObject::cast(*this).JSArgumentsObjectVerify(isolate);
282282
break;
283283
case JS_GENERATOR_OBJECT_TYPE:
@@ -366,10 +366,10 @@ void HeapObject::HeapObjectVerify(Isolate* isolate) {
366366
case JS_PROMISE_TYPE:
367367
JSPromise::cast(*this).JSPromiseVerify(isolate);
368368
break;
369-
case JS_REGEXP_TYPE:
369+
case JS_REG_EXP_TYPE:
370370
JSRegExp::cast(*this).JSRegExpVerify(isolate);
371371
break;
372-
case JS_REGEXP_STRING_ITERATOR_TYPE:
372+
case JS_REG_EXP_STRING_ITERATOR_TYPE:
373373
JSRegExpStringIterator::cast(*this).JSRegExpStringIteratorVerify(isolate);
374374
break;
375375
case FILLER_TYPE:
@@ -426,34 +426,34 @@ void HeapObject::HeapObjectVerify(Isolate* isolate) {
426426
CodeDataContainer::cast(*this).CodeDataContainerVerify(isolate);
427427
break;
428428
#ifdef V8_INTL_SUPPORT
429-
case JS_INTL_V8_BREAK_ITERATOR_TYPE:
429+
case JS_V8_BREAK_ITERATOR_TYPE:
430430
JSV8BreakIterator::cast(*this).JSV8BreakIteratorVerify(isolate);
431431
break;
432-
case JS_INTL_COLLATOR_TYPE:
432+
case JS_COLLATOR_TYPE:
433433
JSCollator::cast(*this).JSCollatorVerify(isolate);
434434
break;
435-
case JS_INTL_DATE_TIME_FORMAT_TYPE:
435+
case JS_DATE_TIME_FORMAT_TYPE:
436436
JSDateTimeFormat::cast(*this).JSDateTimeFormatVerify(isolate);
437437
break;
438-
case JS_INTL_LIST_FORMAT_TYPE:
438+
case JS_LIST_FORMAT_TYPE:
439439
JSListFormat::cast(*this).JSListFormatVerify(isolate);
440440
break;
441-
case JS_INTL_LOCALE_TYPE:
441+
case JS_LOCALE_TYPE:
442442
JSLocale::cast(*this).JSLocaleVerify(isolate);
443443
break;
444-
case JS_INTL_NUMBER_FORMAT_TYPE:
444+
case JS_NUMBER_FORMAT_TYPE:
445445
JSNumberFormat::cast(*this).JSNumberFormatVerify(isolate);
446446
break;
447-
case JS_INTL_PLURAL_RULES_TYPE:
447+
case JS_PLURAL_RULES_TYPE:
448448
JSPluralRules::cast(*this).JSPluralRulesVerify(isolate);
449449
break;
450-
case JS_INTL_RELATIVE_TIME_FORMAT_TYPE:
450+
case JS_RELATIVE_TIME_FORMAT_TYPE:
451451
JSRelativeTimeFormat::cast(*this).JSRelativeTimeFormatVerify(isolate);
452452
break;
453-
case JS_INTL_SEGMENT_ITERATOR_TYPE:
453+
case JS_SEGMENT_ITERATOR_TYPE:
454454
JSSegmentIterator::cast(*this).JSSegmentIteratorVerify(isolate);
455455
break;
456-
case JS_INTL_SEGMENTER_TYPE:
456+
case JS_SEGMENTER_TYPE:
457457
JSSegmenter::cast(*this).JSSegmenterVerify(isolate);
458458
break;
459459
#endif // V8_INTL_SUPPORT

‎src/diagnostics/objects-printer.cc‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -215,25 +215,25 @@ void HeapObject::HeapObjectPrint(std::ostream& os) { // NOLINT
215215
case JS_API_OBJECT_TYPE:
216216
case JS_SPECIAL_API_OBJECT_TYPE:
217217
case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
218-
case JS_ARGUMENTS_TYPE:
218+
case JS_ARGUMENTS_OBJECT_TYPE:
219219
case JS_ERROR_TYPE:
220220
// TODO(titzer): debug printing for more wasm objects
221-
case WASM_EXCEPTION_TYPE:
221+
case WASM_EXCEPTION_OBJECT_TYPE:
222222
JSObject::cast(*this).JSObjectPrint(os);
223223
break;
224-
case WASM_MODULE_TYPE:
224+
case WASM_MODULE_OBJECT_TYPE:
225225
WasmModuleObject::cast(*this).WasmModuleObjectPrint(os);
226226
break;
227-
case WASM_MEMORY_TYPE:
227+
case WASM_MEMORY_OBJECT_TYPE:
228228
WasmMemoryObject::cast(*this).WasmMemoryObjectPrint(os);
229229
break;
230-
case WASM_TABLE_TYPE:
230+
case WASM_TABLE_OBJECT_TYPE:
231231
WasmTableObject::cast(*this).WasmTableObjectPrint(os);
232232
break;
233-
case WASM_GLOBAL_TYPE:
233+
case WASM_GLOBAL_OBJECT_TYPE:
234234
WasmGlobalObject::cast(*this).WasmGlobalObjectPrint(os);
235235
break;
236-
case WASM_INSTANCE_TYPE:
236+
case WASM_INSTANCE_OBJECT_TYPE:
237237
WasmInstanceObject::cast(*this).WasmInstanceObjectPrint(os);
238238
break;
239239
case JS_ASYNC_FUNCTION_OBJECT_TYPE:
@@ -247,10 +247,10 @@ void HeapObject::HeapObjectPrint(std::ostream& os) { // NOLINT
247247
case JS_ARRAY_TYPE:
248248
JSArray::cast(*this).JSArrayPrint(os);
249249
break;
250-
case JS_REGEXP_TYPE:
250+
case JS_REG_EXP_TYPE:
251251
JSRegExp::cast(*this).JSRegExpPrint(os);
252252
break;
253-
case JS_REGEXP_STRING_ITERATOR_TYPE:
253+
case JS_REG_EXP_STRING_ITERATOR_TYPE:
254254
JSRegExpStringIterator::cast(*this).JSRegExpStringIteratorPrint(os);
255255
break;
256256
case ODDBALL_TYPE:
@@ -362,34 +362,34 @@ void HeapObject::HeapObjectPrint(std::ostream& os) { // NOLINT
362362
JSDataView::cast(*this).JSDataViewPrint(os);
363363
break;
364364
#ifdef V8_INTL_SUPPORT
365-
case JS_INTL_V8_BREAK_ITERATOR_TYPE:
365+
case JS_V8_BREAK_ITERATOR_TYPE:
366366
JSV8BreakIterator::cast(*this).JSV8BreakIteratorPrint(os);
367367
break;
368-
case JS_INTL_COLLATOR_TYPE:
368+
case JS_COLLATOR_TYPE:
369369
JSCollator::cast(*this).JSCollatorPrint(os);
370370
break;
371-
case JS_INTL_DATE_TIME_FORMAT_TYPE:
371+
case JS_DATE_TIME_FORMAT_TYPE:
372372
JSDateTimeFormat::cast(*this).JSDateTimeFormatPrint(os);
373373
break;
374-
case JS_INTL_LIST_FORMAT_TYPE:
374+
case JS_LIST_FORMAT_TYPE:
375375
JSListFormat::cast(*this).JSListFormatPrint(os);
376376
break;
377-
case JS_INTL_LOCALE_TYPE:
377+
case JS_LOCALE_TYPE:
378378
JSLocale::cast(*this).JSLocalePrint(os);
379379
break;
380-
case JS_INTL_NUMBER_FORMAT_TYPE:
380+
case JS_NUMBER_FORMAT_TYPE:
381381
JSNumberFormat::cast(*this).JSNumberFormatPrint(os);
382382
break;
383-
case JS_INTL_PLURAL_RULES_TYPE:
383+
case JS_PLURAL_RULES_TYPE:
384384
JSPluralRules::cast(*this).JSPluralRulesPrint(os);
385385
break;
386-
case JS_INTL_RELATIVE_TIME_FORMAT_TYPE:
386+
case JS_RELATIVE_TIME_FORMAT_TYPE:
387387
JSRelativeTimeFormat::cast(*this).JSRelativeTimeFormatPrint(os);
388388
break;
389-
case JS_INTL_SEGMENT_ITERATOR_TYPE:
389+
case JS_SEGMENT_ITERATOR_TYPE:
390390
JSSegmentIterator::cast(*this).JSSegmentIteratorPrint(os);
391391
break;
392-
case JS_INTL_SEGMENTER_TYPE:
392+
case JS_SEGMENTER_TYPE:
393393
JSSegmenter::cast(*this).JSSegmenterPrint(os);
394394
break;
395395
#endif // V8_INTL_SUPPORT

‎src/heap/factory.cc‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1958,16 +1958,16 @@ Handle<JSObject> Factory::CopyJSObjectWithAllocationSite(
19581958

19591959
// We can only clone regexps, normal objects, api objects, errors or arrays.
19601960
// Copying anything else will break invariants.
1961-
CHECK(map->instance_type() == JS_REGEXP_TYPE ||
1961+
CHECK(map->instance_type() == JS_REG_EXP_TYPE ||
19621962
map->instance_type() == JS_OBJECT_TYPE ||
19631963
map->instance_type() == JS_ERROR_TYPE ||
19641964
map->instance_type() == JS_ARRAY_TYPE ||
19651965
map->instance_type() == JS_API_OBJECT_TYPE ||
1966-
map->instance_type() == WASM_GLOBAL_TYPE ||
1967-
map->instance_type() == WASM_INSTANCE_TYPE ||
1968-
map->instance_type() == WASM_MEMORY_TYPE ||
1969-
map->instance_type() == WASM_MODULE_TYPE ||
1970-
map->instance_type() == WASM_TABLE_TYPE ||
1966+
map->instance_type() == WASM_GLOBAL_OBJECT_TYPE ||
1967+
map->instance_type() == WASM_INSTANCE_OBJECT_TYPE ||
1968+
map->instance_type() == WASM_MEMORY_OBJECT_TYPE ||
1969+
map->instance_type() == WASM_MODULE_OBJECT_TYPE ||
1970+
map->instance_type() == WASM_TABLE_OBJECT_TYPE ||
19711971
map->instance_type() == JS_SPECIAL_API_OBJECT_TYPE);
19721972
DCHECK(site.is_null() || AllocationSite::CanTrack(map->instance_type()));
19731973

@@ -2405,7 +2405,7 @@ Handle<JSFunction> Factory::NewFunction(const NewFunctionArgs& args) {
24052405
case JS_ARRAY_TYPE:
24062406
elements_kind = PACKED_SMI_ELEMENTS;
24072407
break;
2408-
case JS_ARGUMENTS_TYPE:
2408+
case JS_ARGUMENTS_OBJECT_TYPE:
24092409
elements_kind = PACKED_ELEMENTS;
24102410
break;
24112411
default:

0 commit comments

Comments
 (0)