[log] improve --perf-basic-prof-only-functions

Matheus Marchini · Commit Bot · commit 5dd33955d5cb · 2018-06-15T12:01:35.000Z
Change --perf-basic-prof-only-functions to also log builtin code creation events, otherwise InterpretedFunctions generated by --interpreted-frames-native-stack will be filtered out. R=yangguo@google.com Change-Id: Ib0623fca88e25c514473a43de56ebbbdcb146f97 Reviewed-on: https://chromium-review.googlesource.com/1100014 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53760}
diff --git a/src/log.cc b/src/log.cc
@@ -327,6 +327,7 @@ void PerfBasicLogger::LogRecordedBuffer(AbstractCode* code, SharedFunctionInfo*,
                                         const char* name, int length) {
   if (FLAG_perf_basic_prof_only_functions &&
       (code->kind() != AbstractCode::INTERPRETED_FUNCTION &&
+       code->kind() != AbstractCode::BUILTIN &&
        code->kind() != AbstractCode::OPTIMIZED_FUNCTION)) {
     return;
   }

Original file line number	Diff line number	Diff line change
`@@ -327,6 +327,7 @@ void PerfBasicLogger::LogRecordedBuffer(AbstractCode* code, SharedFunctionInfo*,`
`327`	`327`	`const char* name, int length) {`
`328`	`328`	`if (FLAG_perf_basic_prof_only_functions &&`
`329`	`329`	`(code->kind() != AbstractCode::INTERPRETED_FUNCTION &&`
	`330`	`+ code->kind() != AbstractCode::BUILTIN &&`
`330`	`331`	`code->kind() != AbstractCode::OPTIMIZED_FUNCTION)) {`
`331`	`332`	`return;`
`332`	`333`	`}`