Skip to content

Commit 5ca478a

Browse files
isheludkoCommit bot
authored andcommitted
[field type tracking] Fix handling of cleared WeakCells.
Previous CL (https://codereview.chromium.org/1522413002) has a typo. BUG=chromium:571402,chromium:514080,chromium:527994,v8:4325 LOG=N Review URL: https://codereview.chromium.org/1541403002 Cr-Commit-Position: refs/heads/master@{#33031}
1 parent 358efce commit 5ca478a

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/objects.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3833,8 +3833,8 @@ MaybeHandle<Map> Map::TryUpdate(Handle<Map> old_map) {
38333833
case DATA: {
38343834
HeapType* new_type = new_descriptors->GetFieldType(i);
38353835
// Cleared field types need special treatment. They represent lost
3836-
// knowledge, so we must first generalize the old_type to "Any".
3837-
if (!FieldTypeIsCleared(new_details.representation(), new_type)) {
3836+
// knowledge, so we must first generalize the new_type to "Any".
3837+
if (FieldTypeIsCleared(new_details.representation(), new_type)) {
38383838
return MaybeHandle<Map>();
38393839
}
38403840
PropertyType old_property_type = old_details.type();

0 commit comments

Comments
 (0)