[api] Deprecate some GetIsolate methods

backes · V8 LUCI CQ · commit 5c4a937aafff · 2025-05-20T12:20:55.000-07:00
Reading the isolate from on-heap objects is deprecated. It is already being checked though that this returns the same as the "current" isolate. Hence start the deprecation process. Uses within V8 have been moved to `Isolate::GetCurrent()` already (https://crrev.com/c/6564467). R=leszeks@chromium.org Bug: 396607238 Change-Id: If51112c2b6c53c40d7872de646253d32bb4cf0d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6563615 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#100398}
diff --git a/include/v8-context.h b/include/v8-context.h
@@ -256,6 +256,9 @@ class V8_EXPORT Context : public Data {
   Maybe<void> DeepFreeze(DeepFreezeDelegate* delegate = nullptr);
 
   /** Returns the isolate associated with a current context. */
+  V8_DEPRECATE_SOON(
+      "Use Isolate::GetCurrent() instead, which is guaranteed to return the "
+      "same isolate since https://crrev.com/c/6458560.")
   Isolate* GetIsolate();
 
   /** Returns the microtask queue associated with a current context. */
diff --git a/include/v8-function-callback.h b/include/v8-function-callback.h
@@ -66,12 +66,12 @@ class ReturnValue {
   V8_INLINE void Set(uint16_t i);
   V8_INLINE void Set(uint32_t i);
   V8_INLINE void Set(uint64_t i);
-  // Fast JS primitive setters
+  // Fast JS primitive setters.
   V8_INLINE void SetNull();
   V8_INLINE void SetUndefined();
   V8_INLINE void SetFalse();
   V8_INLINE void SetEmptyString();
-  // Convenience getter for Isolate
+  // Convenience getter for the Isolate.
   V8_INLINE Isolate* GetIsolate() const;
 
   // Pointer setter: Uncompilable to prevent inadvertent misuse.
diff --git a/include/v8-message.h b/include/v8-message.h
@@ -111,6 +111,9 @@ class V8_EXPORT Message {
   /**
    * Return the isolate to which the Message belongs.
    */
+  V8_DEPRECATE_SOON(
+      "Use Isolate::GetCurrent() instead, which is guaranteed to return the "
+      "same isolate since https://crrev.com/c/6458560.")
   Isolate* GetIsolate() const;
 
   V8_WARN_UNUSED_RESULT MaybeLocal<String> GetSource(
diff --git a/include/v8-object.h b/include/v8-object.h
@@ -795,8 +795,14 @@ class V8_EXPORT Object : public Value {
   /**
    * Return the isolate to which the Object belongs to.
    */
+  V8_DEPRECATE_SOON(
+      "Use Isolate::GetCurrent() instead, which is guaranteed to return the "
+      "same isolate since https://crrev.com/c/6458560.")
   Isolate* GetIsolate();
 
+  V8_DEPRECATE_SOON(
+      "Use Isolate::GetCurrent() instead, which is guaranteed to return the "
+      "same isolate since https://crrev.com/c/6458560.")
   V8_INLINE static Isolate* GetIsolate(const TracedReference<Object>& handle) {
     return handle.template value<Object>()->GetIsolate();
   }
